From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDA4DC433EF for ; Mon, 4 Oct 2021 21:22:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C41606103D for ; Mon, 4 Oct 2021 21:22:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234994AbhJDVYR (ORCPT ); Mon, 4 Oct 2021 17:24:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234470AbhJDVYQ (ORCPT ); Mon, 4 Oct 2021 17:24:16 -0400 Received: from mail-io1-xd29.google.com (mail-io1-xd29.google.com [IPv6:2607:f8b0:4864:20::d29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63CFCC061749 for ; Mon, 4 Oct 2021 14:22:27 -0700 (PDT) Received: by mail-io1-xd29.google.com with SMTP id s20so21961739ioa.4 for ; Mon, 04 Oct 2021 14:22:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=MuilptXu/lrbHdYIjm49Orq1L38EfLHYhkCQZMQN58Y=; b=YxVu7riC7j4LVz42GKgYXGTFCKJqdQPDoBbNgq6DmDMCPYIgq7r0JSZLEMwRUv3grr cdiedFdp4r+iNBBN/mXe7pWqYYu2JUV8jVVKsIYViY6+g5jaCREmtkDy07NScmLqvK+S JgdZ4x2qrsy/bvSg3+wlyjybySzvvSnkRl7J4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=MuilptXu/lrbHdYIjm49Orq1L38EfLHYhkCQZMQN58Y=; b=lXixthvLbfr2aMyAMh1p17UGAhzeCJl+GC4TiPR+OKIWJCounp4F6efmqQfexT9Gx9 mg1pSGOWoMDrYb/AImrNEel227QUR7x5KjNOeukY83gma9uHLc3BvZEpcg1xRjmse3ow 7KafvZSjfiOq8YlQBibekFj7C888LD5V10LAFa9QXvi2F/sPpZP932dNwZY+K709UPn8 CHfAM1iKgBL5qSRuf2FE2ctPJLITbsicUHMPAHW0jTpqTktlP7zDIzgFPoSK7Do/zqoc gEfSd/D0BtF88R3lEVrTc8vZYAgzqqc9JvdgNS9NFSZccXiCt4W420OGoO12DhcB9cfW OvCQ== X-Gm-Message-State: AOAM533DdmGOC+I5tgNZu/kHiZlnch2hEtiJ76nsIezxEn04pw/0N3/X XkzjoOH0KUYo0ZPp4nuzvblfPg== X-Google-Smtp-Source: ABdhPJx1RzTfEn170/4xRIBn0Qw7X57+hgrKnGZ4qAFynZArJaATjwdrmMQXQOmPcAV4ahbaG9Xzng== X-Received: by 2002:a5e:a916:: with SMTP id c22mr10780139iod.211.1633382546674; Mon, 04 Oct 2021 14:22:26 -0700 (PDT) Received: from [192.168.1.112] (c-24-9-64-241.hsd1.co.comcast.net. [24.9.64.241]) by smtp.gmail.com with ESMTPSA id v63sm9635481ioe.17.2021.10.04.14.22.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 Oct 2021 14:22:26 -0700 (PDT) Subject: Re: [PATCH v3 1/8] PCI/AER: Remove ID from aer_agent_string[] To: Naveen Naidu , bhelgaas@google.com, ruscur@russell.cc, oohall@gmail.com Cc: linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Shuah Khan References: From: Shuah Khan Message-ID: Date: Mon, 4 Oct 2021 15:22:25 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/4/21 8:29 AM, Naveen Naidu wrote: > Before 010caed4ccb6 ("PCI/AER: Decode Error Source RequesterID") > the AER error logs looked like: > > pcieport 0000:00:03.0: AER: Corrected error received: id=0018 > pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, id=0018 (Receiver ID) > pcieport 0000:00:03.0: device [1b36:000c] error status/mask=00000040/0000e000 > pcieport 0000:00:03.0: [ 6] BadTLP > > In 010caed4ccb6 ("PCI/AER: Decode Error Source Requester ID"), > the "id" field was removed from the AER error logs, so currently AER > logs look like: > > pcieport 0000:00:03.0: AER: Corrected error received: 0000:00:03:0 > pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver ID) > pcieport 0000:00:03.0: device [1b36:000c] error status/mask=00000040/0000e000 > pcieport 0000:00:03.0: [ 6] BadTLP > > The second line in the above logs prints "(Receiver ID)", even when > there is no "id" in the log line. This is confusing. > Starting your commit log to say that message are confusing and then talk about why will make it easier to understand why the change is needed. > Remove the "ID" from the aer_agent_string[]. The error logs will > look as follows (Sample from dummy error injected by aer-inject): > > pcieport 0000:00:03.0: AER: Corrected error received: 0000:00:03.0 > pcieport 0000:00:03.0: PCIe Bus Error: severity=Corrected, type=Data Link Layer, (Receiver) > pcieport 0000:00:03.0: device [1b36:000c] error status/mask=00000040/0000e000 > pcieport 0000:00:03.0: [ 6] BadTLP > It is good to see before and after messages. However, it will be helpful to know why this change is necessary. It isn't very clear why in this commit log. > Signed-off-by: Naveen Naidu Signed-off-by: Naveen Naidu Extra signed-off-by? > --- > drivers/pci/pcie/aer.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c > index 9784fdcf3006..241ff361b43c 100644 > --- a/drivers/pci/pcie/aer.c > +++ b/drivers/pci/pcie/aer.c > @@ -516,10 +516,10 @@ static const char *aer_uncorrectable_error_string[] = { > }; > > static const char *aer_agent_string[] = { > - "Receiver ID", > - "Requester ID", > - "Completer ID", > - "Transmitter ID" > + "Receiver", > + "Requester", > + "Completer", > + "Transmitter" > }; > > #define aer_stats_dev_attr(name, stats_array, strings_array, \ > @@ -703,7 +703,7 @@ void aer_print_error(struct pci_dev *dev, struct aer_err_info *info) > const char *level; > > if (!info->status) { > - pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent ID)\n", > + pci_err(dev, "PCIe Bus Error: severity=%s, type=Inaccessible, (Unregistered Agent)\n", > aer_error_severity_string[info->severity]); > goto out; > } > thanks, -- Shuah