From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 174EB472793 for ; Wed, 6 May 2026 18:51:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778093479; cv=none; b=MZ/0oEZUopQnH+KGWML16PzQfKec1/kikZJ/rcTaz/hhDorLox9/B9bcLaAhM1wAwtk/c925oiNV0K+d6zAzERPadMwFmaO3sNYDGMn/0VOBxKFVLXt9jdeFZI0brbyJF6zGmoC0T3P03xobj/B9i2kiLcid1fL+l7NGY31fHcs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778093479; c=relaxed/simple; bh=s8SojpSoc+YK02FQkvYYyW4yXNu4hN2c6ETT93ArWJQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V3X9f/LhACEhTsjBndmucT6rL8sfMNvUVPt0pgmEzyZIr4qJgBxD9WyL8M1MmaqExzo5lp5KZQIRruvii7C/f0AJB5f5Yze33JN/D79tlIXoa4tmtzp4i1kukldbOaRXJb6/IKd70XMYgsET5CAC1xA/xVl4QsukfxR3UGu1lCQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com; spf=pass smtp.mailfrom=riscstar.com; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b=yqlozRSf; arc=none smtp.client-ip=209.85.222.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=riscstar.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=riscstar.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="yqlozRSf" Received: by mail-qk1-f180.google.com with SMTP id af79cd13be357-8ef45a6d9dfso3878685a.0 for ; Wed, 06 May 2026 11:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1778093477; x=1778698277; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qVXRMaORBAm1p+hmPERIzD3vaX/XPR3tJcXrI0tApsg=; b=yqlozRSfuCUJJ9D/wW3WpVlAitl6p+MalJd4d+qGeBPP7HHYOs15Ifo4zv4JyQM3RY oHUbujbmeUjmk/O4VeGR+RGnA5ACtoV1slnTP6zjtIbj9FGxzvsCksN3JeAJuUeQBmX1 nRTiF8ZF9styqnDRIE7ecUgF92XqjybzmU2tpys//cSjNx11JXVgSmQFJy+B++GX2ZOC u6zWm0k2NWbcK/N5MW1WjdBqxvdMsVhpGXTL2VLC3zGDINTcSdycmkw83ftcdERHrH5w WiRYxhwO/qEdWGPjZdrnDZShFy8obFYV9aNveGpk9ZuEsT82efZmnwLdExxspdhvUjsj 3Z3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778093477; x=1778698277; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qVXRMaORBAm1p+hmPERIzD3vaX/XPR3tJcXrI0tApsg=; b=cy81hOAWi6SeQ5HQSgj9mIFw2WQjF15aUy93gi6BqkfNk2M9YY7rWJsgf38PX+seoN 9p4u09ppSrRAd8M1l/jeLWwleCjNMKPql0CuB8WicW9Caai4hhRN2lfQEebEN4B9Qym5 Kri3iVwelY0vgFBZxjxRCwB21Ok51rPZszS2fg0kvyMompUyLQALIhnDuh+8ylgN3TC3 H+jgxVO9NwAlK9T504IdzMp4Z64mLRZuqzSHMOCMyuRPPhxlpBLoeoeoJtnR/bb/i3u7 1j+qwhrQRPT9wqcomO2KZDP+HHdOPKemj11Wdd4V7YyBYr4/l3pVqLx5+vyYYUw0xPOT Jjvg== X-Forwarded-Encrypted: i=1; AFNElJ/Yqzsj1Ww5DgGRJPB2ghv16pcbWM63FM16j2/zH19KGIRgwxQOQwidaAeUgl8XrWW7oSednN/+G4lUqQQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwPbNPFbytdFv7srhHhwMZ+iZV57+su9AM/Nl97qwl1+Z+C6jQS z4rzpmlGJ0QkI14tYJd2AQt6fAbP3YNuf5uivHTVdSImiDtKHqVIsOjfwpg+saZGagQ= X-Gm-Gg: AeBDieuxWztC0WDlDXpv1RZ9N887oQhepWFNXjYwcdIenSC8niBWZqWZXhgbj+CY2ug bFC1p9Rgdwrz21n1tJ8rMKFWz++HuHohRzksVzvjrEQknLut1GUT3yCiE80TmN0C5syzr+f1eM4 jsOMbgrhPD147e9eaGfoLI+z7q8Y32lnYctYM12Qk5ahnBmo71QRb7GeWJRzHzeftJEc9VBPcm2 3ka+9466vr3lriPJeAJZCgZYbsz3uXhVvtNdoqWfaJrNmzEQ68LOKkiAtOVGTDeE6eVZf9d7lZF w1hsfPCGm+YHKSfa2UXP7WGUJN5C3qjy/cYASMtyy8tYZG+Yy6UzcK6ysf3C/nJui8cxPWzSEwW aVd+09K87ytqdZ5o8XIOQDVlr+WYnY1SW1NQqh0+u98+ntaNkar6bkqeSappzc7S5ROi8kKOmYK EoLB2utPRuhHC1giBdKOtgrpWZinwgYE2jQJRXfwjwn+1GaoVI4cchz7ZSJQmwQKcLz5ch+38qS w== X-Received: by 2002:a05:620a:1a13:b0:8cf:d804:456a with SMTP id af79cd13be357-904d4c54265mr713100885a.20.1778093476942; Wed, 06 May 2026 11:51:16 -0700 (PDT) Received: from [172.22.22.28] (c-75-72-117-212.hsd1.mn.comcast.net. [75.72.117.212]) by smtp.gmail.com with ESMTPSA id af79cd13be357-8fc293837b5sm1889639085a.10.2026.05.06.11.51.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 11:51:16 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 13:51:12 -0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 09/12] gpio: tc956x: add TC956x/QPS615 support To: Julian Braha , andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, maxime.chevallier@bootlin.com, rmk+kernel@armlinux.org.uk, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, linusw@kernel.org, brgl@kernel.org, arnd@arndb.de, gregkh@linuxfoundation.org Cc: daniel@riscstar.com, mohd.anwar@oss.qualcomm.com, a0987203069@gmail.com, alexandre.torgue@foss.st.com, ast@kernel.org, boon.khai.ng@altera.com, chenchuangyu@xiaomi.com, chenhuacai@kernel.org, daniel@iogearbox.net, hawk@kernel.org, hkallweit1@gmail.com, inochiama@gmail.com, john.fastabend@gmail.com, livelycarpet87@gmail.com, matthew.gerlach@altera.com, mcoquelin.stm32@gmail.com, me@ziyao.cc, prabhakar.mahadev-lad.rj@bp.renesas.com, richardcochran@gmail.com, rohan.g.thomas@altera.com, sdf@fomichev.me, siyanteng@cqsoftware.com.cn, weishangjuan@eswincomputing.com, wens@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260501155421.3329862-1-elder@riscstar.com> <20260501155421.3329862-10-elder@riscstar.com> <1fe6bcb7-b5c0-454f-ad54-5014006edab5@gmail.com> Content-Language: en-US From: Alex Elder In-Reply-To: <1fe6bcb7-b5c0-454f-ad54-5014006edab5@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/2/26 10:42 PM, Julian Braha wrote: > On 5/1/26 16:54, Alex Elder wrote: >> +config GPIO_TC956X >> + tristate "Toshiba TC956X GPIO support" >> + depends on TOSHIBA_TC956X_PCI >> + default m if TOSHIBA_TC956X_PCI > > Hi Alex, > > In your Kconfig changes, this condition 'if TOSHIBA_TC956X_PCI' is dead > code. Since you have the dependency on TOSHIBA_TC956X_PCI, you can just > make the 'default m' unconditional - assuming this is what you intended. I'm not sure I'd call it "dead" but you're right, it's not necessary because it already depends on that symbol. > Perhaps you would prefer to use 'default TOSHIBA_TC956X_PCI', which > would have GPIO_TC956X default to 'm' or 'y' when TOSHIBA_TC956X_PCI is > 'm' or 'y', respectively. Yeah that might be better. I'd like to eventually include COMPILE_TEST as well, and that might need the "if" on the default. I'll find out whenever I test that. This GPIO feature should still be a module even if TOSHIBA_TC956X_PCI is y, because it's not always necessary to enable the GPIO driver (depending on how devicetree defines the PHY resets). So: In drivers/gpio/Kconfig it will be "default m", and for drivers/net/ethernet/stmicro/stmmac/Kconfig it will be default TOSHIBA_TC956X_PCI (at least for now). Thanks a lot for the suggestion. -Alex > - Julian Braha