From: Krzysztof Kozlowski <krzk@kernel.org>
To: Woodrow Douglass <wdouglass@carnegierobotics.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator
Date: Wed, 3 Sep 2025 08:16:21 +0200 [thread overview]
Message-ID: <a527e022-75ad-492e-a3e3-579cacd7d324@kernel.org> (raw)
In-Reply-To: <20250902-pf530x-v2-2-f105eb073cb1@carnegierobotics.com>
On 02/09/2025 23:17, Woodrow Douglass wrote:
> Bindings for the pf530x series of voltage regulators
>
> Signed-off-by: Woodrow Douglass <wdouglass@carnegierobotics.com>
> ---
> .../bindings/regulator/nxp,pf530x-regulator.yaml | 74 ++++++++++++++++++++++
> 1 file changed, 74 insertions(+)
>
Nothing improved and you sent it AFTER you received my feedback.
Don't ignore the comments.
Do not attach (thread) your patchsets to some other threads (unrelated
or older versions). This buries them deep in the mailbox and might
interfere with applying entire sets.
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-03 6:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-02 14:21 [PATCH 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-02 14:21 ` [PATCH 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-02 15:08 ` Mark Brown
2025-09-02 14:21 ` [PATCH 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-02 19:19 ` Krzysztof Kozlowski
2025-09-02 21:17 ` [PATCH v2 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-02 21:17 ` [PATCH v2 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-02 21:17 ` [PATCH v2 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 6:16 ` Krzysztof Kozlowski [this message]
2025-09-03 9:34 ` Mark Brown
2025-09-03 15:31 ` [PATCH v3 0/2] regulator: pf530x: NXP PF530x regulator driver Woodrow Douglass
2025-09-03 15:31 ` [PATCH v3 1/2] regulator: pf530x: Add a driver for the NXP PF5300 Regulator Woodrow Douglass
2025-09-03 15:31 ` [PATCH v3 2/2] regulator: pf530x: dt-bindings: nxp,pf530x-regulator Woodrow Douglass
2025-09-03 20:33 ` Rob Herring (Arm)
2025-09-03 20:46 ` Woody Douglass
2025-09-03 16:08 ` [PATCH v3 0/2] regulator: pf530x: NXP PF530x regulator driver Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a527e022-75ad-492e-a3e3-579cacd7d324@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=wdouglass@carnegierobotics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).