From: shuah <shuah@kernel.org>
To: Davidlohr Bueso <dave@stgolabs.net>, Kees Cook <keescook@chromium.org>
Cc: Stanislav Kinsbursky <skinsbursky@parallels.com>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
shuah <shuah@kernel.org>
Subject: Re: [PATCH] selftests/ipc: Fix msgque compiler warnings
Date: Fri, 19 Apr 2019 13:10:43 -0600 [thread overview]
Message-ID: <a53346cd-9eec-7ca6-3a09-a5558a5c9aa8@kernel.org> (raw)
In-Reply-To: <20190408200141.uusxqlqly6tab6h7@linux-r8p5>
On 4/8/19 2:01 PM, Davidlohr Bueso wrote:
> On Mon, 08 Apr 2019, Kees Cook wrote:
>
>> This fixes the various compiler warnings when building the msgque
>> selftest. The primary change is using sys/msg.h instead of linux/msg.h
>> directly to gain the API declarations.
>>
>> Fixes: 3a665531a3b7 ("selftests: IPC message queue copy feature test")
>> Signed-off-by: Kees Cook <keescook@chromium.org>
>
> (Not really related to this patch)
>
> Given that the selftest/ipc/ only consists of this test, I wonder if
> the test should just be moved to ltp, where the ipc tests are a lot
> more complete and robust -- and which I've been using for years for
> basic testing code changes.
>
Having this test in here helps us find regressions quickly. It does good
and no harm keeping this test in here.
I don't think it is a good idea to remove it all together.
thanks,
-- Shuah
prev parent reply other threads:[~2019-04-19 19:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 17:13 [PATCH] selftests/ipc: Fix msgque compiler warnings Kees Cook
2019-04-08 20:01 ` Davidlohr Bueso
2019-04-19 19:10 ` shuah [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a53346cd-9eec-7ca6-3a09-a5558a5c9aa8@kernel.org \
--to=shuah@kernel.org \
--cc=dave@stgolabs.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=skinsbursky@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox