From: Daniel Sneddon <daniel.sneddon@linux.intel.com>
To: Arnd Bergmann <arnd@kernel.org>,
x86@kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@redhat.com>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/speculation: add cpu_show_gds() prototype
Date: Wed, 9 Aug 2023 08:46:19 -0700 [thread overview]
Message-ID: <a54d1613-7163-ceb5-3c9a-dead97801db7@linux.intel.com> (raw)
In-Reply-To: <20230809130530.1913368-1-arnd@kernel.org>
On 8/9/23 06:04, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added function has two definitions but no prototypes:
>
> drivers/base/cpu.c:605:16: error: no previous prototype for 'cpu_show_gds' [-Werror=missing-prototypes]
>
> Add a declaration next to the other ones for this file to avoid the
> warning.
>
> Fixes: 8974eb588283b ("x86/speculation: Add Gather Data Sampling mitigation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> include/linux/cpu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/cpu.h b/include/linux/cpu.h
> index 9d43b734170d6..0abd60a7987b6 100644
> --- a/include/linux/cpu.h
> +++ b/include/linux/cpu.h
> @@ -73,6 +73,8 @@ extern ssize_t cpu_show_retbleed(struct device *dev,
> struct device_attribute *attr, char *buf);
> extern ssize_t cpu_show_spec_rstack_overflow(struct device *dev,
> struct device_attribute *attr, char *buf);
> +extern ssize_t cpu_show_gds(struct device *dev,
> + struct device_attribute *attr, char *buf);
>
> extern __printf(4, 5)
> struct device *cpu_device_create(struct device *parent, void *drvdata,
Sorry I missed that. Shouldn't stable be CC'd here as well?
Thanks,
Dan
next prev parent reply other threads:[~2023-08-09 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 13:04 [PATCH 1/2] x86/speculation: add cpu_show_gds() prototype Arnd Bergmann
2023-08-09 13:05 ` [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header Arnd Bergmann
2023-08-09 16:54 ` Daniel Sneddon
2023-08-09 18:26 ` Arnd Bergmann
2023-08-09 19:16 ` Daniel Sneddon
2023-08-09 19:20 ` Daniel Sneddon
2023-08-09 15:46 ` Daniel Sneddon [this message]
2023-08-09 22:13 ` [PATCH 1/2] x86/speculation: add cpu_show_gds() prototype Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a54d1613-7163-ceb5-3c9a-dead97801db7@linux.intel.com \
--to=daniel.sneddon@linux.intel.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox