From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91E3BE7B610 for ; Wed, 4 Oct 2023 13:03:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242514AbjJDNDp (ORCPT ); Wed, 4 Oct 2023 09:03:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233003AbjJDNDo (ORCPT ); Wed, 4 Oct 2023 09:03:44 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 123A698; Wed, 4 Oct 2023 06:03:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1696424620; x=1727960620; h=date:from:to:cc:subject:in-reply-to:message-id: references:mime-version; bh=vna89G92+YUSN4xCn006PAPr/J9VzgSDMaNYJ/MQZ/A=; b=jzLjYwPqLrrC3zKVkyidZd8RZ5LYwh5IAJPPqWl3p9KmP0V0D79HKJPG pxUEPce22fdSONXzCFmcS5BknRIrbOkrPvoaGHWO4A+PgkgCQYzpiIzbz k0EyESuymSbfos732Tgxof+Qfzp8Drx+GhOGrkXIgGiePfhM+bAhr+vXl hG+xqAS57EKyfPXCxBEODLdYrE5AyKtiXxwe6KxLpbb/6dRyXs9ac9Xpi uBuM3qyFB/KXiWYIViMbtORcUKTvgp4yRclLUm9ak9/XBHWL8MFnxFMrW YelAKEEAT+ZGy6wO05N/L1KJmrm9ICsrXdLCMfOwbEdkzHSTpismfyqxI w==; X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="385986261" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="385986261" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 06:03:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10853"; a="1082496523" X-IronPort-AV: E=Sophos;i="6.03,200,1694761200"; d="scan'208";a="1082496523" Received: from cyrillet-mobl.ger.corp.intel.com ([10.252.55.203]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Oct 2023 06:03:33 -0700 Date: Wed, 4 Oct 2023 16:03:31 +0300 (EEST) From: =?ISO-8859-15?Q?Ilpo_J=E4rvinen?= To: Andy Shevchenko cc: Srinivas Pandruvada , Hans de Goede , markgross@kernel.org, platform-driver-x86@vger.kernel.org, LKML Subject: Re: [PATCH v2 1/3] platform/x86/intel/tpmi: Add defines to get version information In-Reply-To: Message-ID: References: <20231003184916.1860084-1-srinivas.pandruvada@linux.intel.com> <20231003184916.1860084-2-srinivas.pandruvada@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Oct 2023, Andy Shevchenko wrote: > On Tue, Oct 03, 2023 at 11:49:14AM -0700, Srinivas Pandruvada wrote: > > Add defines to get major and minor version from a TPMI version field > > value. This will avoid code duplication to convert in every feature > > driver. Also add define for invalid version field. > > ... > > > +#define TPMI_VERSION_INVALID 0xff > > I would make it clearer with (GENMASK(7, 5) | GENMASK(4, 0)) > or even with specific masks defined and used in both cases: > #def > > #define TPMI_MINVER_MASK GENMASK(4, 0) > #define TPMI_MAJVER_MASK GENMASK(7, 5) > > #define TPMI_VERSION_INVALID (TPMI_MINVER_MASK | TPMI_MAJVER_MASK) > > #define TPMI_MINOR_VERSION(val) FIELD_GET(TPMI_MINVER_MASK, val) > #define TPMI_MAJOR_VERSION(val) FIELD_GET(TPMI_MAJVER_MASK, val) > > > +#define TPMI_MINOR_VERSION(val) FIELD_GET(GENMASK(4, 0), val) > > +#define TPMI_MAJOR_VERSION(val) FIELD_GET(GENMASK(7, 5), val) In case somebody does, please do it on top of the existing changes as I already applied the series. -- i.