From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010059.outbound.protection.outlook.com [40.93.198.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9718B12D1F1 for ; Tue, 24 Mar 2026 05:04:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.93.198.59 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774328692; cv=fail; b=G2xCHoh1d0MmIKbtN8fSHUtb+EE+ZfuOHDx+Zzs7j5DaXMjzOD0PGKGBA+sYX1dr6j2iIRgcAjv0cLx6q4xvkpCDLXxNpI8k/27nQT/fVKuvVvzfSJKEDirInlt4I3xouBoaTosRjdYpsA2bpjLhdJHm9i89t+KIIZOZSqWMXD0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774328692; c=relaxed/simple; bh=bQbZG2CUuTHqOxaETTa/PsxKttvSTRska8LB/8K2uPE=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=PdrEeOUvuS/Z9X9hqUEedt/4Fy0FY8XGiwprA+DYcK+X1PiyMpmkT1kOeFQZwASCVh/CD/CrvbE/9vh7UBDmtpxrT/9Rr5tdRWLzoYsez3hrT0H3U0SI5DYT14Phv5qBdz1OD2Z7vxGwc5JR2cX8X/beZODwUEU2inQH8NmKF2Y= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=spFwmvRo; arc=fail smtp.client-ip=40.93.198.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="spFwmvRo" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=a9JNbrcmXw7mdXvJe7p3U6Z70zoFDI0YIeFs2Aw/LVLpHe18MRMlAnhRESUqhORzjHHK2oHx5REvub+vv3/7cBGFqAQmlJ47ev24MpNsEGkgtHJUWHHhciEEpa1sFRSNBdDHjqX8nr7w8P/8Y3xOaxaFXjAo75kcixsXbzRtvpnmQUk+X4kyYfpXB6YxuJMygi8Z5F5cRsjfo0IUnAXrUYC/og4jx3bUf16RfG7rOs0o2adbPjoscGWdkJ7zUzVg+s06bDD841nHQNXazdVqjVrzXdaQ9/m3RkQv8TLTgp1zc8eULjMyrmXQvyrfJcymx9z27faczLizWXKyQ25zqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QYC9rZfVzw1FJyxVOtyvGAXoz9Xg1vSL+sTNRKHlHtU=; b=TufXI7T6LcS3dwVfJV1xuz2m6r3WFQC5T5Kus+IcbAJ6HWw1e8Lx4B6ZTvRv8IJ23PoMUhOuvxBmoWrbjCSfGDefRcAPj9yqJxwtkN0Eu0FdNgG+Qi8HpS13PU/gAX0QmEOfLs+bSIZMFwq1tUKjmylN07lFpewXYDZ8KqLvsW2O5ztAS4ftzPJHAUhrbz95yVmUTPcvAABFp8627gZQ6W5cSwwUrDMJpzPlO4nGY8BLMMyh8WzIGmSgeBiCaWAdB6SpJDrAcDjJXPVqvlvp3n7Nwfph4Ah8ucHwqzARPhMpsZFqL48IB3o2EJlCw4LU7Q1nLNWweJzCRZjC1i0HgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=QYC9rZfVzw1FJyxVOtyvGAXoz9Xg1vSL+sTNRKHlHtU=; b=spFwmvRoBZUjPZxv+mb+Z6IsFAALbvH4ooPpCeBCHqcv0ZxekJ/3Z4Ayr6zhKg5Tw6kRTntzxmRqP+W92OjhmFvwLqHfqIge5BnZXEaMcs/Kv0A44pfhNeUPw872nxXeA4schwdYEuEo2bLhICuBljOwe6BbHoZsbrUWuKJTR24= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from BN9PR12MB5259.namprd12.prod.outlook.com (2603:10b6:408:100::17) by DS0PR12MB7804.namprd12.prod.outlook.com (2603:10b6:8:142::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9745.20; Tue, 24 Mar 2026 05:04:48 +0000 Received: from BN9PR12MB5259.namprd12.prod.outlook.com ([fe80::122c:cca7:c2b3:90ed]) by BN9PR12MB5259.namprd12.prod.outlook.com ([fe80::122c:cca7:c2b3:90ed%3]) with mapi id 15.20.9745.019; Tue, 24 Mar 2026 05:04:48 +0000 Message-ID: Date: Tue, 24 Mar 2026 10:34:41 +0530 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/migrate: rename PAGE_ migration flags to FOLIO_MF_ To: "David Hildenbrand (Arm)" , Matthew Wilcox Cc: Andrew Morton , Zi Yan , Matthew Brost , Joshua Hahn , Rakie Kim , Byungchul Park , Gregory Price , Ying Huang , Alistair Popple , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20260323141935.389232-3-shivankg@amd.com> <7095112e-465d-49bf-9cbd-98e6e6ad2aa0@kernel.org> Content-Language: en-US From: "Garg, Shivank" In-Reply-To: <7095112e-465d-49bf-9cbd-98e6e6ad2aa0@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PN4P287CA0130.INDP287.PROD.OUTLOOK.COM (2603:1096:c01:2b1::10) To BN9PR12MB5259.namprd12.prod.outlook.com (2603:10b6:408:100::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN9PR12MB5259:EE_|DS0PR12MB7804:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b3ced9c-9f76-4531-7a29-08de8962df77 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: SY7eSTS0sY5r20pPF7vFXLz9V0Jir2wFM6lkhKvtEtZNiYMu4c9zNb/0ou6+kuPnVkMfftc28TgpKGro0uHnyqHthmemJt/9qqs0CIV3Jazy1X1BtEzIzysWi4VCl1ElYtM1T4nDl7UgSybfpOLkdHEKO9Po0ZcRqMwvaizmqUbdoDHX1vfnzUCY34CCy713WhsSJXsxqdZClkIHkB7UnEqvnuxtJLLIWqdtfbtCNakQSwTOhM4I9SXno8zx2vFkyIPlaNUYtqqE0BWieRLmT84SZ79IbN41gWVRooXjkxAqRq7HsenMeO8XT1WLajTDt8cCNnOeHHKQZTyqUQGqyFaCWNvGdGcWPa5y7UAlgoQEY+56zN0VIOGS/dS8ro757T7WIWVR5tcASjaqFP2new4Aq8ifH2QnIvlU6HCoWUbz6GDK5aY0XR1Zf7YpF5VdMvjVSYEw29iY+Fd0Eto64We2THYQ3btErXkYP8H+JG9ZGyAJvqT4XHHvs0ObYBCHb6Cg2I5lu2fdHtCFz9V5xo5a6dSTTqgqv08ivS6Qo5+NI254NklEzC0rj7Fa7xBehkgQK7Ag8rsES2EUiMRzV+YL2Qvec5BtQIg1HVCx7cmfdTciHud95/0G74fs63Pm0Nc8PP9I4GLZ669i5ZquTOW8HSM1IOgM/YqKqf8U88zkTsLHI1WtTbXa6hEL3JyIphFFxF2O+1JWMn39m08VggSElZCaLilVmtZf6Tyu3nc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BN9PR12MB5259.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dkR2Skd3eU9USytyRTFHa0VxSW9jeFZyK1F4UXlJSTN1WmRUQlh1bUZRV2Ix?= =?utf-8?B?UXZmSXZkMllKbFlQVzIxN1dYQ01rSW5uSGNIMmFJckJrY3prVlo1SGpXQUNX?= =?utf-8?B?QUVYTlUwZUtMVzBscFhvc2MvS3RZdzE2TVk4TUx4NHVXZEx1OTlYYURlS0s3?= =?utf-8?B?UkJPMVhwRlZCZkhxNzdQWVM0U2hndXRmNXJkUm5BRUoxeFE4VWFEV1p5KzZw?= =?utf-8?B?SFBodDVCZTJwV2tVLzkxTDlZRU5yMjZodGtMd3NLVHg3Z3U4bWNuSXd4LzNT?= =?utf-8?B?ais4NjJzWUsvN1Bwc3Jxb0p3WEx2Rmg4UzRZaTZ6a3d2Z1F5WVZGY3BVS3BZ?= =?utf-8?B?UEIzNSt4eWljRUJreTcwOW1hMXRjMSsrUDRoZkVPN0RHdnRWT2pCWmo1Qmoy?= =?utf-8?B?ZDZSaUtRU3I3ZGhPRXNLVEQ4YXFCZ0czTWVsOTN1cC9ETFJhUFROT1VWNzBY?= =?utf-8?B?REpTamx2SlhNdDNCa2tma2R2aUtRWVVKczkwcXpjakQwSmFpV0EwaHhuMldX?= =?utf-8?B?MHlKdjYzWUhiTkw3aDZvNHJkUmJXWHprWjdGY29obVMzd3J6NEhORk8rbXFU?= =?utf-8?B?QTVwWmVyclBBVWFQcEZQRjI2bXpOTU01MXIzUTBsTG91MjZicmdLcVMvV0Ft?= =?utf-8?B?TUMwWGUvYlVPb256ZWVJUFJ0TXhQUzZrKzMwU2JIQlVRczJEaStiVDBBM25N?= =?utf-8?B?Y0hyMFN4VWplU2tGMllTVEp3QSs2MkpzU1hncGFwR1dlY1MrWHN1SE1YNGpS?= =?utf-8?B?Y3JUQ0lZdXhSbTVqMk5OQS80WS9QTUhJcEdRaUR1cWNsaytmaW1xdE1FdEFa?= =?utf-8?B?SllDa1FGRmxTR3h4V0NqV3hncWlNU2xWRGZKS3VBN3EwQkFyaUhrRG90UVVw?= =?utf-8?B?ZW1VOVZKNUdtTWhhd1pHdS91dlU2MnM5VnhuZG9aWEx2VWNmMG5yUC8vdGEy?= =?utf-8?B?cEFycWlqSFpOZVgzc0tPUHd4dzJmcXRCZnBKQVhUMXNzbjl2bXhaRkZvZmgr?= =?utf-8?B?bXlQVFdvSmlvTmpzZjgxRFVMZ0doWkd2bVk1R0hndEF2ajAzK2cwaUpUaVFX?= =?utf-8?B?VWxYamlraDRROGYyWlM5aFVKMnphaWRNN2lmTEpkN3ozd1RKNzJubTdlZnpa?= =?utf-8?B?TFFFWTNRSVYwOElXeWdUUHcxUlFORmhlRm5DeVVTbFVibUhWL3JUWXJJaXgr?= =?utf-8?B?OE9GQ1daUzdETStYL3k2aXllRmVBUFFZbXVNMnVrTjlvWnlhSjYzbUxUNmpH?= =?utf-8?B?TTNOTEtmWlpIRzZUL0Z0RzRkSTRURmRuVGhodzhqV3pPSnNWTkJTYWJsUmlu?= =?utf-8?B?ZkF0cC9VczNRY0N6UmN3L1N3UHNSU2xvM3RJUlNjYzh6a3ZGVjVHalNtaDRz?= =?utf-8?B?RFdrT3l0WlFFZXN4RS9Mbzd5N1I3cjgzblRvM3ZySVl1NmZab0pkc2lQQWhr?= =?utf-8?B?S0t1dFdXdzFUOHZ1Y096U25TVVpVbGVTKzM5YjI0UWFPSXZrcUdWN01VRGw0?= =?utf-8?B?Wkl6eTJLSmh0UWRSU09KWkpZMDlMWXpTQkdPMkVsQWZ3aHI4NWFOMFBlVWJt?= =?utf-8?B?b0Ezb3hJdWhVRFJuNlk3eFlQWnJFSEI0Rmw2OVBtc0pTanpkSFV4emluM3Zz?= =?utf-8?B?dEhUc3h2MTNtY0h2bGVBYlA2a05kSTdtSXRhcDFldkNZcUs1K05lVGN6VDZO?= =?utf-8?B?MWxkR3M3S0FWb2U1akZDNTlyT0NPaHBrKzlLcTRmVFJKMVRzNkRHUi8vYTdq?= =?utf-8?B?T3FnRUs1Mml2QnhtUk5raldzd2pWUUZ0N0d6TFFubFpYaHdWYyt6M3pxMy81?= =?utf-8?B?N0w1QWtGNlR0Y0tBcnhhZllPaVNLR0x3VFQ4VFFyWTQ2UGFDME4wTlR2T2Iw?= =?utf-8?B?bkVmRU9aS2hGNW9GZ2o0a0I0VE82cDRZVVdrem51U3RFNzFxaXJRYURlL20v?= =?utf-8?B?WTk2RGpZY3djNFZNMXBiN283TElEUEIzbWUzamdGSUVQYWRMcFV5MHQ1NVhW?= =?utf-8?B?aGVFS0Y1UTRLdjZTdTQvbDgzQWt0UmpvL3RuTG5nYmY0am5mQTBXQUJHNlo4?= =?utf-8?B?REFFMW5NNUh4VkJVYldITkE1Z29hTkFIRDJRcmNmc0FRZkt5dWx4QjlhZmpB?= =?utf-8?B?Tk9FeERoQngwUFZHQ09lWHFKZW5QbmpOQ0hzM05ieE9NZ2RCbnRON3Mxa1dz?= =?utf-8?B?c25VMnJ6bHNsaGpzNHNtWGFlYWZyd1hvNnViemErRFFhTXhYb1hUYS9yb1Zs?= =?utf-8?B?STRSTUY1RXM3NlpnVXNlMTJ4THZjSHFkVXU2RmNReTZaQjhaZlBSSlRXU1Fo?= =?utf-8?B?UGllVVIrL3BuZGdERStGbzBVdExSR0s0a3lMWUhtU0pZeG4xQlRWZz09?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b3ced9c-9f76-4531-7a29-08de8962df77 X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5259.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Mar 2026 05:04:48.3413 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mkWPdF49TyoEb9W6teBEugFdhpZp3sSgxoQVlvyeFDiEHMTHRg6XdVPVNKkR8T8JCH21F6VvSJW+t8VTYVHH+w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7804 On 3/24/2026 12:51 AM, David Hildenbrand (Arm) wrote: > On 3/23/26 19:57, Matthew Wilcox wrote: >> On Mon, Mar 23, 2026 at 04:36:38PM +0100, David Hildenbrand (Arm) wrote: >>> On 3/23/26 15:46, Matthew Wilcox wrote: >>>> >>>> I mean, this doesn't make sense any more. PAGE_WAS_MLOCKED is a >>>> sentence that means something. FOLIO_MF_WAS_MLOCKED doesn't ... unless >>>> you imagine Samuel L Jackson saying it ... >>> >>> :) >>> >>> PAGE_WAS_MLOCKED was suboptimal given that the names overlap with things >>> like PAGE_SHARED or even PAGE_IS_PRESENT. >> >> PAGE_SHARED (and friends) are misnamed because really they're PTE flags, >> not page flags. Then PAGE_IS_* form a namespace for pagemap, which I >> think is fine. These are PAGE_WAS, so a distinct namespace already. >> >>> So using some prefix to indicate that these flag belong logically >>> together makes sense. Even if it's not a beautiful sentence. >> >> FOLIO_WAS_ seems like a fine namespace. Especially since it's local to >> this file. > > Right, given that it's local to the file that's ok. > Thanks, I will send V2 with FOLIO_WAS_*. Best regards, Shivank