The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "Chen, Yu C" <yu.c.chen@intel.com>
To: "Moger, Babu" <bmoger@amd.com>
Cc: Ben Horgan <ben.horgan@arm.com>,
	James Morse <james.morse@arm.com>,
	"Dave Martin" <Dave.Martin@arm.com>,
	Babu Moger <babu.moger@amd.com>,
	Drew Fustini <fustini@kernel.org>,
	Fenghua Yu <fenghuay@nvidia.com>, Borislav Petkov <bp@alien8.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	Peter Newman <peternewman@google.com>,
	"x86@kernel.org" <x86@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Reinette Chatre <reinette.chatre@intel.com>,
	"Luck, Tony" <tony.luck@intel.com>,
	"chen.yu@linux.dev" <chen.yu@linux.dev>
Subject: Re: [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept
Date: Fri, 7 Aug 2026 23:35:37 +0800	[thread overview]
Message-ID: <a5663ea4-484b-48ad-9fc8-1919b2f4cb4b@intel.com> (raw)
In-Reply-To: <c1137f17-801d-43dd-a442-159fad34e47f@amd.com>

Hi Babu,

On 8/7/2026 10:14 PM, Moger, Babu wrote:

[ ... ]

>>> Is same needed for x86? I don't see any initialization of the
>>> "r_ctrl.emulated_by" lists in similar initialization functions.
>> x86 "emulated_by" list initialization should be in both branches.
>>
>> Branch resctrl/controls_rfc_v2.1 combined all "emulated_by" list 
>> initialization
>> (for x86 and MPAM) into commit:
>> 3407e523c988 ("fs/resctrl: Introduce emulated controls and control mode")
>>
>> In the original resctrl/controls_rfc_v2 the x86 "emulated_by" list 
>> initialization can
>> be found in commit fbed64f80515 ("x86/resctrl: SAMPLE: Emulated 
>> controls")
>>
> 
> Looking at the commit:
> 
> commit 3407e523c988 ("fs/resctrl: Introduce emulated controls and 
> control mode")
> 
> Based on the patch description, emulated controls are intended to be 
> used only when there is a difference between the native and legacy 
> controls. If no such difference exists, both modes should operate 
> identically.
> 
> For MBA(AMD) and GMBA, there does not appear to be any difference 
> between the two modes. Is that understanding correct?
> 

Yes I think so. __rdt_get_mem_config_amd() does
INIT_LIST_HEAD(&hw_ctrl->r_ctrl.emulated_by), so the list is
a valid empty one and resctrl_enabled_ctrl_iter_next() short-circuits
on list_empty() regardless of ctrl_mode, meaning MBA
expose the same single control in either mode.

thanks,
Chenyu

  parent reply	other threads:[~2026-08-07 15:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-04  5:26 [RFC v2] arm,x86,fs/resctrl: Generic schema description Proof of Concept Reinette Chatre
2026-08-05 16:59 ` Ben Horgan
2026-08-05 23:57   ` Reinette Chatre
2026-08-06 17:04     ` Luck, Tony
2026-08-06 17:11       ` Reinette Chatre
2026-08-07 14:14         ` Moger, Babu
2026-08-07 15:35           ` Reinette Chatre
2026-08-07 18:33             ` Moger, Babu
2026-08-07 22:53               ` Reinette Chatre
2026-08-07 15:35           ` Chen, Yu C [this message]
2026-08-07 17:57             ` Moger, Babu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5663ea4-484b-48ad-9fc8-1919b2f4cb4b@intel.com \
    --to=yu.c.chen@intel.com \
    --cc=Dave.Martin@arm.com \
    --cc=babu.moger@amd.com \
    --cc=ben.horgan@arm.com \
    --cc=bmoger@amd.com \
    --cc=bp@alien8.de \
    --cc=chen.yu@linux.dev \
    --cc=dave.hansen@linux.intel.com \
    --cc=fenghuay@nvidia.com \
    --cc=fustini@kernel.org \
    --cc=james.morse@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peternewman@google.com \
    --cc=reinette.chatre@intel.com \
    --cc=tglx@linutronix.de \
    --cc=tony.luck@intel.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox