From: Richard Gong <richard.gong@linux.intel.com>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node
Date: Tue, 28 Apr 2020 09:14:25 -0500 [thread overview]
Message-ID: <a583b842-585d-888e-49e5-32a16dfab8a6@linux.intel.com> (raw)
In-Reply-To: <20200428083238.GA21288@bogus>
Hi,
On 4/28/20 3:32 AM, Sudeep Holla wrote:
> On Mon, Apr 27, 2020 at 02:12:56PM -0500, Richard Gong wrote:
>> Hi Sudeep,
>>
>> In our dts, firmware is not under root node. You can refer to
>> arch/arm64/boot/dts/altera/socfpga_stratix10.dtsi for details.
>>
>> This is why we need check and populate firmware node.
>>
>
> Ah that's bad. One of very few DTS I see firmware node not in the root.Per the Devicetree Specification, there is no need to define firmware
under the root node. Some examples are fsl-ls1012a.dtsi and
hi6220-hikey.dts.
> But this driver is the only one duplicating the codethen Commit 3aa0582fdb82 should be extended to handle firmware which is
not defined under the root node. I am not sure if it is doable.
>
Regards,
Richard
next prev parent reply other threads:[~2020-04-28 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-21 17:32 [PATCH] firmware: stratix10-svc: Drop unnecessary checking for and populating /firmware/ node Sudeep Holla
2020-04-22 21:50 ` Richard Gong
2020-04-23 8:11 ` Sudeep Holla
2020-04-27 19:12 ` Richard Gong
2020-04-28 8:32 ` Sudeep Holla
2020-04-28 14:14 ` Richard Gong [this message]
2020-04-28 14:11 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a583b842-585d-888e-49e5-32a16dfab8a6@linux.intel.com \
--to=richard.gong@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox