From: Krzysztof Kozlowski <krzk@kernel.org>
To: nina_kuo@novatek.com.tw
Cc: andi.shyti@kernel.org, ben_huang@novatek.com.tw,
conor+dt@kernel.org, devicetree@vger.kernel.org,
krzk+dt@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, robh@kernel.org,
shihpei_hsu@novatek.com.tw, toby_chui@novatek.com.tw
Subject: Re: [PATCH v4 1/3] dt-bindings: i2c: Add Novatek NT72676 I2C controller
Date: Fri, 31 Jul 2026 12:18:21 +0200 [thread overview]
Message-ID: <a59c01f3-e930-41b6-bf6a-3cce92f301e6@kernel.org> (raw)
In-Reply-To: <20260731101035.599828-1-nina_kuo@novatek.com.tw>
On 31/07/2026 12:10, nina_kuo@novatek.com.tw wrote:
> From: Ben Huang <Ben_Huang@novatek.com.tw>
>
> On Friday, July 31, 2026 5:34 PM, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>> +description: |
>>
>> Do not need '|' unless you need to preserve formatting.
>
> '|' will be removed for the next iteration.
>
>> You miss clocks.
> Currently, the I2C input clock rates are hard-coded in i2c-nt72676.c, which is
> not ideal.
>
Driver is irrelevant here.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-07-31 10:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 7:25 [PATCH v4 0/3] i2c: Add Novatek NT72676 SoC I2C controller nina_kuo
2026-07-30 7:25 ` [PATCH v4 1/3] dt-bindings: i2c: Add Novatek NT72676 " nina_kuo
2026-07-31 9:34 ` Krzysztof Kozlowski
2026-07-31 10:10 ` nina_kuo
2026-07-31 10:18 ` Krzysztof Kozlowski [this message]
2026-07-31 10:24 ` nina_kuo
2026-07-30 7:25 ` [PATCH v4 2/3] i2c: nt72676: Add Novatek NT72676 I2C controller driver nina_kuo
2026-07-30 7:25 ` [PATCH v4 3/3] MAINTAINERS: Add entry for " nina_kuo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a59c01f3-e930-41b6-bf6a-3cce92f301e6@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=ben_huang@novatek.com.tw \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nina_kuo@novatek.com.tw \
--cc=robh@kernel.org \
--cc=shihpei_hsu@novatek.com.tw \
--cc=toby_chui@novatek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox