From: Ivan Vecera <ivecera@redhat.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>,
Prathosh Satish <Prathosh.Satish@microchip.com>,
Jakub Kicinski <kuba@kernel.org>, Arnd Bergmann <arnd@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] dpll: zl3073x: ZL3073X_I2C and ZL3073X_SPI should depend on NET
Date: Mon, 4 Aug 2025 17:32:54 +0200 [thread overview]
Message-ID: <a5c159e6-75d0-433d-92b4-f5be3fc0c1c2@redhat.com> (raw)
In-Reply-To: <20250802155302.3673457-1-geert+renesas@glider.be>
On 02. 08. 25 5:53 odp., Geert Uytterhoeven wrote:
> When making ZL3073X invisible, it was overlooked that ZL3073X depends on
> NET, while ZL3073X_I2C and ZL3073X_SPI do not, causing:
>
> WARNING: unmet direct dependencies detected for ZL3073X when selected by ZL3073X_I2C
> WARNING: unmet direct dependencies detected for ZL3073X when selected by ZL3073X_SPI
> WARNING: unmet direct dependencies detected for ZL3073X
> Depends on [n]: NET [=n]
> Selected by [y]:
> - ZL3073X_I2C [=y] && I2C [=y]
> Selected by [y]:
> - ZL3073X_SPI [=y] && SPI [=y]
>
> Fix this by adding the missing dependencies to ZL3073X_I2C and
> ZL3073X_SPI.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202508022110.nTqZ5Ylu-lkp@intel.com/
> Closes: https://lore.kernel.org/oe-kbuild-all/202508022351.NHIxPF8j-lkp@intel.com/
> Fixes: a4f0866e3dbbf3fe ("dpll: Make ZL3073X invisible")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/dpll/zl3073x/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/dpll/zl3073x/Kconfig b/drivers/dpll/zl3073x/Kconfig
> index 9915f7423dea370c..5bbca14005813134 100644
> --- a/drivers/dpll/zl3073x/Kconfig
> +++ b/drivers/dpll/zl3073x/Kconfig
> @@ -16,7 +16,7 @@ config ZL3073X
>
> config ZL3073X_I2C
> tristate "I2C bus implementation for Microchip Azurite devices"
> - depends on I2C
> + depends on I2C && NET
> select REGMAP_I2C
> select ZL3073X
> help
> @@ -28,7 +28,7 @@ config ZL3073X_I2C
>
> config ZL3073X_SPI
> tristate "SPI bus implementation for Microchip Azurite devices"
> - depends on SPI
> + depends on NET && SPI
> select REGMAP_SPI
> select ZL3073X
> help
Acked-by: Ivan Vecera <ivecera@redhat.com>
next prev parent reply other threads:[~2025-08-04 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-02 15:53 [PATCH] dpll: zl3073x: ZL3073X_I2C and ZL3073X_SPI should depend on NET Geert Uytterhoeven
2025-08-04 15:32 ` Ivan Vecera [this message]
2025-08-05 0:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c159e6-75d0-433d-92b4-f5be3fc0c1c2@redhat.com \
--to=ivecera@redhat.com \
--cc=Prathosh.Satish@microchip.com \
--cc=arnd@kernel.org \
--cc=geert+renesas@glider.be \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).