From: David Ahern <dsahern@kernel.org>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>, davem@davemloft.net
Cc: yoshfuji@linux-ipv6.org, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] ipv6: ICMPV6: Use swap() instead of open coding it
Date: Tue, 31 Jan 2023 09:03:00 -0700 [thread overview]
Message-ID: <a5c9ea73-9a00-e858-9aeb-54e0061e9172@kernel.org> (raw)
In-Reply-To: <20230131063456.76302-1-jiapeng.chong@linux.alibaba.com>
On 1/30/23 11:34 PM, Jiapeng Chong wrote:
> Swap is a function interface that provides exchange function. To avoid
> code duplication, we can use swap function.
>
> ./net/ipv6/icmp.c:344:25-26: WARNING opportunity for swap().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=3896
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> net/ipv6/icmp.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2023-01-31 16:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 6:34 [PATCH] ipv6: ICMPV6: Use swap() instead of open coding it Jiapeng Chong
2023-01-31 12:55 ` Simon Horman
2023-01-31 16:03 ` David Ahern [this message]
2023-02-02 4:00 ` patchwork-bot+netdevbpf
-- strict thread matches above, loose matches on Subject: below --
2022-01-13 16:17 Jiapeng Chong
2022-01-14 4:30 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5c9ea73-9a00-e858-9aeb-54e0061e9172@kernel.org \
--to=dsahern@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox