From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751599AbdAWV3P (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 16:29:15 -0500
Received: from mga03.intel.com ([134.134.136.65]:46511 "EHLO mga03.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750714AbdAWV3N (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 16:29:13 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,275,1477983600"; 
   d="scan'208";a="56360372"
Subject: Re: [tip:x86/urgent] x86/fpu: Set the xcomp_bv when we fake up a
 XSAVES area
To: Yu-cheng Yu <yu-cheng.yu@intel.com>
References: <1485075023-30161-1-git-send-email-haokexin@gmail.com>
 <tip-5fa356458b5c918bdf8307b070a3d74bc015d910@git.kernel.org>
 <f2fb890d-f8ff-69e2-acc7-b3c810d6cf02@linux.intel.com>
 <20170123165529.GA4996@test-lenovo>
 <2be814b7-9fd6-7955-b4e3-6ecb4ef76052@linux.intel.com>
 <20170123205725.GA3920@test-lenovo>
 <90b0fbee-273b-31c2-6fe9-228f00c0a205@linux.intel.com>
 <20170123211640.GA3976@test-lenovo>
Cc: fenghua.yu@intel.com, dvlasenk@redhat.com, peterz@infradead.org,
        oleg@redhat.com, mingo@kernel.org, linux-kernel@vger.kernel.org,
        brgerst@gmail.com, luto@kernel.org, bp@alien8.de, jpoimboe@redhat.com,
        haokexin@gmail.com, hpa@zytor.com, quentin.casasnovas@oracle.com,
        tglx@linutronix.de, torvalds@linux-foundation.org, riel@redhat.com,
        linux-tip-commits@vger.kernel.org
From: Dave Hansen <dave.hansen@linux.intel.com>
Message-ID: <a5ca287e-382d-3407-63de-3c75ae617aac@linux.intel.com>
Date: Mon, 23 Jan 2017 13:28:20 -0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <20170123211640.GA3976@test-lenovo>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/23/2017 01:16 PM, Yu-cheng Yu wrote:
> On Mon, Jan 23, 2017 at 01:10:20PM -0800, Dave Hansen wrote:
>> The code is:
>>
>>> void fpstate_init(union fpregs_state *state)
>>> {
>>>         if (!static_cpu_has(X86_FEATURE_FPU)) {
>>>                 fpstate_init_soft(&state->soft);
>>>                 return;
>>>         }
>>>
>>>         memset(state, 0, fpu_kernel_xstate_size);
>>>
>>>         /*
>>>          * XRSTORS requires that this bit is set in xcomp_bv, or
>>>          * it will #GP. Make sure it is replaced after the memset().
>>>          */
>>>         if (static_cpu_has(X86_FEATURE_XSAVES))
>>>                 state->xsave.header.xcomp_bv = XCOMP_BV_COMPACTED_FORMAT;
>>
>> That seems to set it unconditionally.  What am I missing?
> 
> The fix I am proposing is...
> 
> 	state->xsave.header.xcomp_bv = XCOMP_BV_COMPACTED_FORMAT |
> 				       xfeatures_mask;

Ahh, that makes sense.  That does indeed look like a bug in fpstate_init().