From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AH8x226C0qafNR2Y6yoOkwvsaPtJUwOF+m+p/siSuQfa/GCCAR8wj6JUPwSaHXP2YBqiMF5zzFIx ARC-Seal: i=1; a=rsa-sha256; t=1519363369; cv=none; d=google.com; s=arc-20160816; b=w4CxK+j9O7E2fXKyuLD+vO1Q60XWpIfDm39Vykyt9/+kyEsdLa+am/8VMvCaAzjsSR ZCfOEFPOF7Q2maX3diTWyo0Rf5DOeLhzXFUIhnCk4XR71oGFkr4rZPQ3iXtEpEOLUWQR AiGt4Hdiu1KRYFoVtqufEYWC0AU4OgAsTbn2dEcZPG99K6ATz+RIJljXA37W/j21FLrG vY+u9QdcYM1T6l/ScuO/RkCidiXb2ePluC5SWoJ4wk/iT+SPpb7RTr8It9MMRzkH/6/b moxE3aoBrWktKQYE4L5fH1yUYT6ylSBCVl+ZizPfNtUCBzewxFMGtNTjVHFeL3Lg25aE 8ODA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:message-id:references:in-reply-to:subject:cc:to:from :date:content-transfer-encoding:mime-version:dkim-signature :dkim-signature:arc-authentication-results; bh=0ir9cgn2M37Et+EDfAwu+fpzaZhAwaqcxzqctE47aCY=; b=R6GDVRo247zX3L+nJ4Hi3ZwiCq1kF2LgYOWpYoB4NoKyK3kfCzqRfFpoT+atjWF2hR RIU8Thxvku7ImVrYKt+RTrmnu6o03dpU47j6avYDMeLyUmQ+PoCCNPNSjitnN88IY1Cy 5b7TsB6ZQOCSOdBGGilJVGlFwzqB9el2TYvPNv4+XIzcD0TUIaLxsB0XDkqZhOy/r0Og uDSwc5dNMag8lpyJS9WeEKmL7xtNM59bV02zvwtqToWxgMinewXWIw3Wb0W39yfcRIH5 3ZP+uEoTrYD9L/XwDH3yyXffZVfrZ5SzwskRitIPn4HDR6JYcHDd5psXD3ovFWN7Gmzl tU1Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Y+tnyV1A; dkim=pass header.i=@codeaurora.org header.s=default header.b=nAHdDquY; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=Y+tnyV1A; dkim=pass header.i=@codeaurora.org header.s=default header.b=nAHdDquY; spf=pass (google.com: domain of poza@codeaurora.org designates 198.145.29.96 as permitted sender) smtp.mailfrom=poza@codeaurora.org MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 23 Feb 2018 10:52:47 +0530 From: poza@codeaurora.org To: Randy Dunlap Cc: Bjorn Helgaas , Philippe Ombredanne , Thomas Gleixner , Greg Kroah-Hartman , Kate Stewart , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Dongdong Liu , Keith Busch , Wei Zhang , Sinan Kaya , Timur Tabi Subject: Re: [PATCH v9 7/7] PCI/DPC: Enumerate the devices after DPC trigger event In-Reply-To: References: <1519285571-5634-1-git-send-email-poza@codeaurora.org> <1519285571-5634-8-git-send-email-poza@codeaurora.org> Message-ID: User-Agent: Roundcube Webmail/1.2.5 X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1593086428728217914?= X-GMAIL-MSGID: =?utf-8?q?1593167964375344829?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 2018-02-23 00:53, Randy Dunlap wrote: > On 02/21/2018 11:46 PM, Oza Pawandeep wrote: >> Implement error_resume callback in DPC so, after DPC trigger event >> enumerates the devices beneath. >> >> Signed-off-by: Oza Pawandeep >> >> diff --git a/drivers/pci/pcie/pcie-dpc.c b/drivers/pci/pcie/pcie-dpc.c >> index fce4518..59c01c7 100644 >> --- a/drivers/pci/pcie/pcie-dpc.c >> +++ b/drivers/pci/pcie/pcie-dpc.c >> @@ -129,6 +129,23 @@ static void dpc_wait_link_inactive(struct dpc_dev >> *dpc) >> } >> >> /** >> + * dpc_error_resume - enumerate the devices beneath >> + * @dev: pointer to Root Port's pci_dev data structure > > * @pdev: ... > >> + * >> + * Invoked by Port Bus driver during nonfatal recovery. >> + */ >> +static void dpc_error_resume(struct pci_dev *pdev) >> +{ >> + bool active = true; >> + >> + if (pci_wait_for_link(pdev, active)) { >> + pci_lock_rescan_remove(); >> + pci_rescan_bus(pdev->bus); >> + pci_unlock_rescan_remove(); >> + } >> +} >> + >> +/** >> * dpc_reset_link - reset link DPC routine >> * @dev: pointer to Root Port's pci_dev data structure >> * >> diff --git a/drivers/pci/pcie/pcie-err.c b/drivers/pci/pcie/pcie-err.c >> index 6844347..4950f49 100644 >> --- a/drivers/pci/pcie/pcie-err.c >> +++ b/drivers/pci/pcie/pcie-err.c >> @@ -256,6 +258,15 @@ static pci_ers_result_t >> broadcast_error_message(struct pci_dev *dev, >> result_data.result = PCI_ERS_RESULT_RECOVERED; >> >> if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE) { >> + /* If DPC is triggered, call resume error hanlder > > handler > > Kernel multi-line comment style is: > /* > * Begin comment here. > * foo bar blah > */ > >> + * because, at this point we can safely assume that >> + * link recovery has happened. >> + */ >> + if ((severity == DPC_FATAL) && >> + (cb == report_resume)) { >> + cb(dev, NULL); >> + return PCI_ERS_RESULT_RECOVERED; >> + } >> /* >> * If the error is reported by a bridge, we think this error >> * is related to the downstream link of the bridge, so we > > thanks, Thanks for the comments, All your comments are taken care in v10, though I will post v11.