From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C6A0E1FE47B for ; Sat, 6 Jun 2026 15:01:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780758099; cv=none; b=ayewgaTg0SEly/bxpsxi5Q4KStJA0b9cUMnuvoxizDI5iCjoqUzpHD/jofA7JtWUv9M7HUQWarzW1EC1G0fvEQhb/rB4vlgwn8HgdxczC27I87CkX5D80pi+z7C64ApAxAdPgBpMUTOYKcklhOUR2r6BuFb7hHXwq+VzhvYa/Go= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780758099; c=relaxed/simple; bh=Q7bvcNgJBR0xuXybvJDUiVtpofQYpuoyQGJUe+NPFBU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Hva7XxjIVaCJqvwCIVj4oDdMf44Xf65H9gRgiy2LZqGkCFuONw6ww08ky+beF6mN4FE0/zPuKm5mvAdxUOUz+fN/AojYRd1wCZWIKW2iXKlm+1zfXiqDTYtSEPCSCS4ZM8WSahqm23xK6SxFmJBI/47dLf8Jzur4CHsWJB5/WtY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=c8f7BAO9; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="c8f7BAO9" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4908b92904fso32870605e9.0 for ; Sat, 06 Jun 2026 08:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780758096; x=1781362896; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Q7bvcNgJBR0xuXybvJDUiVtpofQYpuoyQGJUe+NPFBU=; b=c8f7BAO9NBT1bmm7IlC03FBkQdql/LMFu+ynTcKEKX8LxAPayqKSEY3wKFrDMa4KrS dAK+63rIL2yVAmi2wMvzQihE0pQLBxITm6Xkzq2r44ABw4aCS9eTihxA0SfZ8uU31sTN Yp3hrU+xFgp+xbKFDHw6j9y0VPu4/a0ZG6YJEIiicH3wyWEuSsfJM9jp2Qk0N3QGnQJ9 Jcf+Mexai8N46jQ1im+GY6lMwOw6leRSEDurx4FLobsegcz1cBLdCzVL20zU6W4r1Gkn e1PoW39rmMjHMmhr+xv0Q77Nu/+RD/sIDUfmZNMoWBAZz5iI9cGyxE0Evx8PNScn/JuL 4NdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780758096; x=1781362896; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q7bvcNgJBR0xuXybvJDUiVtpofQYpuoyQGJUe+NPFBU=; b=oeHx9+H7rhSpnZl+LZgeBp4mBlVPKJYldDvAiyHXAXoaTIxl5Sd1I0leQlzVj8OX3u VfakeLLlfHIMz5XBgGGH3cOm4P/Fsc1cSdnPBS5w+58+Wv3twyS0FRiZSW6q7YDrkmbt 1ZNiMU0CtkozmlgcowXHBALEcmtxfM98RmMW+QxZoZxHi8giqQ0HGkqHhi8AsZcuT6at jUp+vDdvt7CYhOLbWVo3TVP1uuh3DZGZtBgcxPs05gwGNiTEvA29kehR0JmxKxjfwjdl +Y1p1MMA7E8+DSWlbvChaB+9ahDid0hu9Hdvdaq4UAv52Z6h887z/iR0yTe0ualgbqhp Q1zQ== X-Forwarded-Encrypted: i=1; AFNElJ/3+LX/QZyW4g/nSyOi7W56s6GKAIylBXIG/kmTjOjGgp0yPMoKWTLlnlRzNE4uhsvBbH8jRGGwemlPhAY=@vger.kernel.org X-Gm-Message-State: AOJu0YyZrjAseMqNvH58SKpbhVHr5HHAMl8p4VV7KZImPkNRvKe9LM0J UIgcCyf3KdXxrLhg2+DdtEHu3fVk3OFN2kZEabj9Ov+pDM5p/NDinmJo X-Gm-Gg: Acq92OH7y+oLa9a1IgA4OhZ3Wpeto3GN1FLsKMuGjXhLX0eKcyeTHZJ8oJCquelH4T8 m7A+8hIlINc/vsLH3MxeaXvTW/fFSNGCKIm4vHo6rMV8g3JnnCLo//DAfm+rOu7Lh2A7RqXgrwl a8TyzjW9sbYhPwdOVS+IvP1/1fHPF+UCEqxnoNspejKcFdfuDvcTipDTQgLboJEk8EnHZdCdf0w wvVBvWjdswu2NpY1eGFkNm7xHpX+HvQUiDAsj13caWQ9BOWR2PMzVvNgRIpaj4SF0mNtrq3qUDh PAwVFwdt9jrJutd3clEBbLcnDZ3pC7Wcc51piIHlcsDdXxsvTZ5Kd/kF78rV3T6AXbl7PJ+9GN+ ADF2T4Cyc0CCstWJIMR9uSmMxUbO9CC/zjmm585dSlbNK/kscRNgUZI8kEsoEP/url1WRsA/RrJ YHdiHAZCRkLB8xV9+dmjifL8D84o2CNFTXHazsqNewsQsaTpLuhQI9l+jA1pAGQRbIkhbYSgKDH KrZqHLvuzxeXQxjTuMxCLmf6EBL0g== X-Received: by 2002:a05:600c:3ba1:b0:490:b072:1be6 with SMTP id 5b1f17b1804b1-490c2633778mr146118015e9.25.1780758096032; Sat, 06 Jun 2026 08:01:36 -0700 (PDT) Received: from [10.128.10.215] (195-23-151-163.net.novis.pt. [195.23.151.163]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-490bc3cc140sm290985935e9.9.2026.06.06.08.01.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Jun 2026 08:01:35 -0700 (PDT) Sender: Julian Braha Message-ID: Date: Sat, 6 Jun 2026 16:01:34 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] kconfig: warn on dead default To: Sam Ravnborg Cc: nathan@kernel.org, nsc@kernel.org, rdunlap@infradead.org, masahiroy@kernel.org, grahamr@qti.qualcomm.com, nico@fluxnic.net, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org References: <20260606140008.271929-1-julianbraha@gmail.com> <20260606142326.GA117482@ravnborg.org> Content-Language: en-US From: Julian Braha In-Reply-To: <20260606142326.GA117482@ravnborg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 6/6/26 15:23, Sam Ravnborg wrote: > I looks redundant with the two loops were we for the latter knows it is > a P_DEFAULT. Hi Sam, It may look redundant, but we do need to check each default we encounter in the ``` for (prop = sym->prop; prop; prop = prop->next) { ``` loop against the previous defaults to know if we've encountered a duplicate default condition. I guess the other approach would be to copy each default as we encounter them into a hashtable and check against that, instead? Let me know if you have another, preferred approach. - Julian Braha