linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pratik R. Sampat" <prsampat@amd.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
	ashish.kalra@amd.com, thomas.lendacky@amd.com,
	john.allen@amd.com, herbert@gondor.apana.org.au, bp@alien8.de,
	michael.roth@amd.com, aik@amd.com, pbonzini@redhat.com
Subject: Re: [PATCH 1/1] crypto: ccp - Add the SNP_VERIFY_MITIGATION command
Date: Wed, 9 Jul 2025 10:14:17 -0500	[thread overview]
Message-ID: <a5dbf066-a999-42d4-8d0f-6dae66ef0b98@amd.com> (raw)
In-Reply-To: <aG0jxWk1eor1A_Gd@google.com>

Hi Sean,

On 7/8/25 8:57 AM, Sean Christopherson wrote:
> On Mon, Jun 30, 2025, Pratik R. Sampat wrote:
>> The SEV-SNP firmware provides the SNP_VERIFY_MITIGATION command, which
>> can be used to query the status of currently supported vulnerability
>> mitigations and to initiate mitigations within the firmware.
>>
>> See SEV-SNP Firmware ABI specifications 1.58, SNP_VERIFY_MITIGATION for
>> more details.
> 
> Nothing here explains why this needs to be exposed directly to userspace.

The general idea is that not all mitigations may/can be applied
immediately, for ex: some mitigations may require all the guest to be
shutdown before they can be applied. So a host userspace interface to
query+apply mitigations can be useful for that coordination before
attempting to apply the mitigation.

I also realized that I could use SNP_FEATURE_INFO's cached results from
Ashish's CipherTextHiding series[1] to save us a firmware call if the
verify mitigation in the ECX vector is unsupported.

[1]: https://lore.kernel.org/kvm/cover.1751397223.git.ashish.kalra@amd.com/

Thanks,
Pratik 

  reply	other threads:[~2025-07-09 15:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-30 20:23 [PATCH 0/1] Support for SNP_VERIFY_MITIGATION command Pratik R. Sampat
2025-06-30 20:23 ` [PATCH 1/1] crypto: ccp - Add the " Pratik R. Sampat
2025-07-08 13:57   ` Sean Christopherson
2025-07-09 15:14     ` Pratik R. Sampat [this message]
2025-07-10 22:45       ` Sean Christopherson
2025-07-16 18:25         ` Pratik R. Sampat
2025-07-18 15:33           ` Sean Christopherson
2025-07-24 16:23             ` Pratik R. Sampat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5dbf066-a999-42d4-8d0f-6dae66ef0b98@amd.com \
    --to=prsampat@amd.com \
    --cc=aik@amd.com \
    --cc=ashish.kalra@amd.com \
    --cc=bp@alien8.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=john.allen@amd.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael.roth@amd.com \
    --cc=pbonzini@redhat.com \
    --cc=seanjc@google.com \
    --cc=thomas.lendacky@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).