public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@kernel.dk>
To: "Kiselev, Oleg" <okiselev@amazon.com>,
	Philipp Reisner <philipp.reisner@linbit.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Lars Ellenberg <lars.ellenberg@linbit.com>,
	Christoph Hellwig <hch@lst.de>,
	"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
	"Herrenschmidt, Benjamin" <benh@amazon.com>,
	"Smith, Stewart" <trawets@amazon.com>
Subject: Re: [Drbd-dev] state of drbd in mainline
Date: Wed, 30 Mar 2022 14:21:35 -0600	[thread overview]
Message-ID: <a5fbb7f3-8b0a-eef9-6479-dedc9fc6a425@kernel.dk> (raw)
In-Reply-To: <7AD2D6DC-0609-42F9-A481-B6E5C0F58180@amazon.com>

On 3/30/22 1:31 PM, Kiselev, Oleg wrote:
> AWS RDS is a major user of drbd.  We are probably responsible for the
> substantial percentage of drbd users in the world.  We are currently
> on drbd-8.4.  We will eventually migrate to drbd-9, but at our scale
> this isn't going to happen very soon.  
> 
> The last time we needed to patch drbd was back in 2018.  We've not
> diagnosed any reportable issues with drbd-8.4 in the past ~4 years.
> It's a stable, mature driver.   We would prefer for drbd-8 to continue
> being available in the upstream tree.  We'd also welcome drbd-9 being
> available in-tree as soon as possible: it will make life much easier
> for other AWS teams that are currently working on DRBD deployment.

Thanks for the info, that's useful and good to know. My objection was as
much about ignoring patches that are sent for drbd, I don't recall
seeing any replies to those kinds of emails in the last 3-4 years. Part
of maintaining an in-tree driver is also dealing with those in a
reasonable amount of time, and ensuring that they make it upstream. And
the one bug fix that does look important was just sent upstream only
because of this discussion, and that's been lingering for a year it
seems.

Roughly ordered by date:

https://lore.kernel.org/all/20220327070918.8465-1-xiam0nd.tong@gmail.com/
https://lore.kernel.org/all/1648436049-4335-1-git-send-email-baihaowen@meizu.com/
https://lore.kernel.org/all/YbpERiPKO4ufe1hf@pc638.lan/
https://lore.kernel.org/all/20211213223331.135412-11-keescook@chromium.org/
[PATCH 0/2] drbd: Make use of PFN_UP helper macro (only on drbd list)
https://lore.kernel.org/all/20210525065925.3978-1-lyl2019@mail.ustc.edu.cn/
https://lore.kernel.org/all/1619774456-116567-1-git-send-email-jiapeng.chong@linux.alibaba.com/
https://lore.kernel.org/all/20210426163032.3454129-1-christoph.boehmwalder@linbit.com/ (the referenced patch)
https://lore.kernel.org/all/20210402070713.4069-1-lyl2019@mail.ustc.edu.cn/ (use after free, security issue?)
https://lore.kernel.org/all/20201026215043.3893318-1-arnd@kernel.org/

This is just going back a bit, by no means an exhaustive list. Looking back
to 2016-2017 and I see zero replies in emails like the above, not one.
Everybody misses patches here and there, that's common. What isn't common
is blatantly ignoring everything for, what, 5 years?

I'm not here to babysit unmaintained drivers. linbit need to get their
act together and maintain the driver, or it will get removed.

-- 
Jens Axboe


  reply	other threads:[~2022-03-30 20:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-29  7:06 state of drbd in mainline Christoph Hellwig
2022-03-29  7:24 ` Philipp Reisner
     [not found] ` <CADGDV=UgjZAbmAN-2bO1nyDvA=XCC9Lf2dxWHZ0BwxF12nnztQ@mail.gmail.com>
2022-03-29  7:32   ` Christoph Hellwig
2022-03-29  7:50     ` Philipp Reisner
2022-03-29 12:29       ` Jens Axboe
2022-03-29 15:44         ` Philipp Reisner
2022-03-29 15:52           ` Jens Axboe
2022-03-30 15:23             ` Philipp Reisner
2022-03-30 18:06               ` Mike Snitzer
2022-03-30 18:24               ` Jens Axboe
2022-03-30 19:31               ` [Drbd-dev] " Kiselev, Oleg
2022-03-30 20:21                 ` Jens Axboe [this message]
2022-03-29 20:01     ` Wolfgang Walter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a5fbb7f3-8b0a-eef9-6479-dedc9fc6a425@kernel.dk \
    --to=axboe@kernel.dk \
    --cc=benh@amazon.com \
    --cc=drbd-dev@lists.linbit.com \
    --cc=hch@lst.de \
    --cc=lars.ellenberg@linbit.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=okiselev@amazon.com \
    --cc=philipp.reisner@linbit.com \
    --cc=trawets@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox