From: Sinan Kaya <okaya@codeaurora.org>
To: Oza Pawandeep <poza@codeaurora.org>,
Bjorn Helgaas <bhelgaas@google.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Dongdong Liu <liudongdong3@huawei.com>,
Keith Busch <keith.busch@intel.com>, Wei Zhang <wzhang@fb.com>,
Timur Tabi <timur@codeaurora.org>
Subject: Re: [PATCH v6 7/7] PCI: Unify wait for link active into generic pci
Date: Fri, 19 Jan 2018 09:08:05 -0500 [thread overview]
Message-ID: <a61cd3d4-ae7b-9ef3-944d-952021cca0e4@codeaurora.org> (raw)
In-Reply-To: <1516360204-1586-8-git-send-email-poza@codeaurora.org>
On 1/19/2018 6:10 AM, Oza Pawandeep wrote:
> +check_link:
> + pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
> + ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
> +
> + if (ret == active) {
> + dev_printk(KERN_DEBUG, &pdev->dev,
> + "%s: lnk_status = %x\n", __func__, lnk_status);
> + return true;
> + }
> +
> + while (timeout > 0) {
> + msleep(10);
> + timeout -= 10;
> + goto check_link;
> + }
this is weird.
I think following is a simpler approach.
pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
while ((ret != active) && (timeout > 0)) {
msleep(10);
timeout -= 10;
pcie_capability_read_word(pdev, PCI_EXP_LNKSTA, &lnk_status);
ret = !!(lnk_status & PCI_EXP_LNKSTA_DLLLA);
}
--
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2018-01-19 14:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-19 11:09 [PATCH v6 0/7] Address error and recovery for AER and DPC Oza Pawandeep
2018-01-19 11:09 ` [PATCH v6 1/7] PCI/AER: Rename error recovery to generic pci naming Oza Pawandeep
2018-01-19 11:09 ` [PATCH v6 2/7] PCI/AER: factor out error reporting from AER Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 3/7] PCI/ERR: add mutex to synchronize recovery Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 4/7] PCI/DPC: Unify and plumb error handling into DPC Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 5/7] PCI/AER: Unify aer error defines at single space Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 6/7] PCI/DPC: Enumerate the devices after DPC trigger event Oza Pawandeep
2018-01-19 11:10 ` [PATCH v6 7/7] PCI: Unify wait for link active into generic pci Oza Pawandeep
2018-01-19 14:08 ` Sinan Kaya [this message]
2018-01-19 14:17 ` Sinan Kaya
2018-01-19 16:22 ` poza
2018-01-19 14:19 ` Stefan Roese
2018-01-19 15:58 ` poza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a61cd3d4-ae7b-9ef3-944d-952021cca0e4@codeaurora.org \
--to=okaya@codeaurora.org \
--cc=bhelgaas@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=keith.busch@intel.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liudongdong3@huawei.com \
--cc=pombredanne@nexb.com \
--cc=poza@codeaurora.org \
--cc=tglx@linutronix.de \
--cc=timur@codeaurora.org \
--cc=wzhang@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox