public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuah@kernel.org>
To: Tejun Heo <tj@kernel.org>, Roman Gushchin <guro@fb.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>,
	Michal Hocko <mhocko@suse.com>,
	Mike Rapoport <rppt@linux.vnet.ibm.com>,
	kernel-team@fb.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org, Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH v2] selftests/cgroup: memory controller self-tests
Date: Thu, 10 May 2018 13:29:07 -0600	[thread overview]
Message-ID: <a652ce44-07f9-d229-70d4-4376bfbafa40@kernel.org> (raw)
In-Reply-To: <20180510183224.GP2368884@devbig577.frc2.facebook.com>

On 05/10/2018 12:32 PM, Tejun Heo wrote:
> On Thu, May 10, 2018 at 05:37:01PM +0100, Roman Gushchin wrote:
>> Cgroups are used for controlling the physical resource distribution
>> (memory, CPU, io, etc) and often are used as basic building blocks
>> for large distributed computing systems. Even small differences
>> in the actual behavior may lead to significant incidents.
>>
>> The codebase is under the active development, which will unlikely
>> stop at any time soon. Also it's scattered over different
>> kernel subsystems, which makes regressions more probable.
>>
>> Given that, the lack of any tests is crying.
>>
>> This patch implements some basic tests for the memory controller,
>> as well as a minimal required framework.
>> It doesn't pretend for a very good coverage, but pretends
>> to be a starting point.
>>
>> Hopefully, any following significant changes will
>> include corresponding tests.
>>
>> Tests for CPU and io controllers, as well as cgroup core
>> are next in the todo list.
> 
> This is great.  Applying to cgroup/for-4.18.
> 
> Thanks a lot.
> 

Don't pull them yet. If Roman can redo the patches on linux-kselftest next,
he can pick up the SKIP changes.

thanks,
-- Shuah

  reply	other threads:[~2018-05-10 19:29 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10 16:37 [PATCH v2] selftests/cgroup: memory controller self-tests Roman Gushchin
2018-05-10 18:32 ` Tejun Heo
2018-05-10 19:29   ` Shuah Khan [this message]
2018-05-11 14:32     ` Tejun Heo
2018-05-11 14:55       ` Shuah Khan
2018-05-11 16:29         ` Tejun Heo
2018-05-11 16:58           ` Shuah Khan
2018-05-11 18:03             ` Roman Gushchin
2018-05-11 19:33               ` Shuah Khan
2018-05-11 20:02                 ` Tejun Heo
2018-05-11 20:22                   ` Shuah Khan
2018-05-18 19:24                     ` Shuah Khan
2018-05-10 19:45 ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a652ce44-07f9-d229-70d4-4376bfbafa40@kernel.org \
    --to=shuah@kernel.org \
    --cc=guro@fb.com \
    --cc=hannes@cmpxchg.org \
    --cc=kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=mhocko@suse.com \
    --cc=rppt@linux.vnet.ibm.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox