* [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
@ 2024-08-10 14:52 Frank Li
2024-08-10 15:02 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Frank Li @ 2024-08-10 14:52 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Ioana Ciornei,
open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
Replace additionalProperties with unevaluatedProperties because it have
allOf: $ref: ethernet-controller.yaml#.
Remove all properties, which already defined in ethernet-controller.yaml.
Fixed below CHECK_DTBS warnings:
arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- Remove properties, which already defined in ethernet-controller.yaml
---
.../bindings/net/fsl,qoriq-mc-dpmac.yaml | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
index a1b71b35319e7..0a91d839382d0 100644
--- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
+++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
@@ -24,24 +24,10 @@ properties:
maxItems: 1
description: The DPMAC number
- phy-handle: true
-
- phy-connection-type: true
-
- phy-mode: true
-
- pcs-handle:
- maxItems: 1
- description:
- A reference to a node representing a PCS PHY device found on
- the internal MDIO bus.
-
- managed: true
-
required:
- reg
-additionalProperties: false
+unevaluatedProperties: false
examples:
- |
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties
2024-08-10 14:52 [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
@ 2024-08-10 15:02 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2024-08-10 15:02 UTC (permalink / raw)
To: Frank Li, David S. Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Ioana Ciornei, open list:NETWORKING DRIVERS,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
open list
Cc: imx
On 10/08/2024 16:52, Frank Li wrote:
> Replace additionalProperties with unevaluatedProperties because it have
> allOf: $ref: ethernet-controller.yaml#.
>
> Remove all properties, which already defined in ethernet-controller.yaml.
>
> Fixed below CHECK_DTBS warnings:
> arch/arm64/boot/dts/freescale/fsl-lx2160a-bluebox3.dtb:
> fsl-mc@80c000000: dpmacs:ethernet@11: 'fixed-link' does not match any of the regexes: 'pinctrl-[0-9]+'
> from schema $id: http://devicetree.org/schemas/misc/fsl,qoriq-mc.yaml#
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - Remove properties, which already defined in ethernet-controller.yaml
> ---
> .../bindings/net/fsl,qoriq-mc-dpmac.yaml | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> index a1b71b35319e7..0a91d839382d0 100644
> --- a/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> +++ b/Documentation/devicetree/bindings/net/fsl,qoriq-mc-dpmac.yaml
> @@ -24,24 +24,10 @@ properties:
> maxItems: 1
> description: The DPMAC number
>
> - phy-handle: true
> -
> - phy-connection-type: true
> -
> - phy-mode: true
> -
> - pcs-handle:
> - maxItems: 1
> - description:
> - A reference to a node representing a PCS PHY device found on
> - the internal MDIO bus.
pcs-handle must stay because you must limit number of items.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-08-10 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-10 14:52 [PATCH v2 1/1] dt-bindings: net: fsl,qoriq-mc-dpmac: using unevaluatedProperties Frank Li
2024-08-10 15:02 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox