Re: [PATCH v2 4/6] platform/x86: asus-armoury: add apu-mem control support

["Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1229 bytes --]

On Sun, 11 Aug 2024, Luke Jones wrote:

> On Tue, 6 Aug 2024, at 10:20 PM, Ilpo Järvinen wrote:
> > On Tue, 6 Aug 2024, Luke D. Jones wrote:
> > 
> > > Implement the APU memory size control under the asus-armoury module using
> > > the fw_attributes class.
> > > 
> > > This allows the APU allocated memory size to be adjusted depending on
> > > the users priority. A reboot is required after change.
> > > 
> > > Signed-off-by: Luke D. Jones <luke@ljones.dev>
> > > ---

> > > + sysfs_notify(kobj, NULL, attr->attr.name);
> > > +
> > > + asus_set_reboot_and_signal_event();
> > > +
> > > + return count;
> > > +}
> > > +
> > > +static ssize_t apu_mem_possible_values_show(struct kobject *kobj,
> > > + struct kobj_attribute *attr, char *buf)
> > > +{
> > > + return sysfs_emit(buf, "0;1;2;3;4;5;6;7;8\n");
> 
> Ack all
> 
> > IIRC, space or newline is the usual separator for possible values sysfs 
> > files. I don't think I've ever seen ; used.
> 
> The docs specify this format. https://github.com/torvalds/linux/blob/5189dafa4cf950e675f02ee04b577dfbbad0d9b1/Documentation/ABI/testing/sysfs-class-firmware-attributes#L56

Okay, I didn't know. Please use what's documented then.

-- 
 i.