public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Edward Liaw <edliaw@google.com>
Cc: "Shuah Khan" <shuah@kernel.org>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	"Darren Hart" <dvhart@infradead.org>,
	"Davidlohr Bueso" <dave@stgolabs.net>,
	"André Almeida" <andrealmeid@igalia.com>,
	"Nysal Jan K . A" <nysal@linux.ibm.com>,
	"Mark Brown" <broonie@kernel.org>,
	"Valentin Obst" <kernel@valentinobst.de>,
	linux-kselftest@vger.kernel.org,
	LKML <linux-kernel@vger.kernel.org>,
	llvm@lists.linux.dev
Subject: Re: [PATCH 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler
Date: Tue, 28 May 2024 15:43:35 -0700	[thread overview]
Message-ID: <a666bb5c-ba85-4b57-bfdb-217da150fb36@nvidia.com> (raw)
In-Reply-To: <CAG4es9Vi3Kmvb0Nn2FNGmVL2YB_5qcJHunUaTRuSy=mkiLhb0Q@mail.gmail.com>

On 5/28/24 3:24 PM, Edward Liaw wrote:
> On Wed, May 8, 2024 at 2:05 PM John Hubbard <jhubbard@nvidia.com> wrote:
>>
>> On 5/2/24 9:18 PM, John Hubbard wrote:
>>> It's slightly better to set _GNU_SOURCE in the source code, but if one
>>> must do it via the compiler invocation, then the best way to do so is
>>> this:
>>
>> Hi Shuah, Edward and all,
>>
>> This patch now seems to be obsolete, due to Edward Liaw's comprehensive
>> fix, "[PATCH v2 0/5] Define _GNU_SOURCE for sources using" [1].
>>
>> [1] https://lore.kernel.org/20240507214254.2787305-1-edliaw@google.com
> 
> Since we're dropping that patch, would we be able to merge this one?
> This should resolve the futex_requeue_pi compiler warnings with Clang.
> 
> Reviewed-by: Edward Liaw <edliaw@google.com>

Thanks for the review! I can post a v2 of this tiny series that has only
patches 1 and 3, rebased on -rc1, so that it's clear what to merge.


thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2024-05-28 22:43 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-03  4:18 [PATCH 0/3] selftests/futex: clang-inspired fixes John Hubbard
2024-05-03  4:18 ` [PATCH 1/3] selftests/futex: don't redefine .PHONY targets (all, clean) John Hubbard
2024-05-03  4:18 ` [PATCH 2/3] selftests/futex: don't pass a const char* to asprintf(3) John Hubbard
2024-05-03  4:18 ` [PATCH 3/3] selftests/futex: pass _GNU_SOURCE without a value to the compiler John Hubbard
2024-05-08 21:05   ` John Hubbard
2024-05-28 22:24     ` Edward Liaw
2024-05-28 22:43       ` John Hubbard [this message]
2024-05-06 16:13 ` [PATCH 0/3] selftests/futex: clang-inspired fixes Davidlohr Bueso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a666bb5c-ba85-4b57-bfdb-217da150fb36@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=andrealmeid@igalia.com \
    --cc=broonie@kernel.org \
    --cc=dave@stgolabs.net \
    --cc=dvhart@infradead.org \
    --cc=edliaw@google.com \
    --cc=kernel@valentinobst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=llvm@lists.linux.dev \
    --cc=mingo@redhat.com \
    --cc=nysal@linux.ibm.com \
    --cc=peterz@infradead.org \
    --cc=shuah@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox