From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-13.ptr.blmpb.com (sg-1-13.ptr.blmpb.com [118.26.132.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFFD221DAD for ; Sat, 8 Nov 2025 10:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762596674; cv=none; b=bS+5yUUWhC2dji3YxC+2rsS7M4h8KkQG1h6C466JkjReWMwkS/ADiCNVSef3r54rJKjpmxOkP69UZH3cqx9s/vbJG8i9WtTabpp18n26siKxPl9PaDW38FhznE35bXKoPkAx2jZ+0s0Loma/lqnv3NzxSqqaoofgIpgsgfE6uiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762596674; c=relaxed/simple; bh=UTMz9mZ8CrbmD3tm8n1OmiyowE5CZV81u5Xc34gm1Dg=; h=Date:Mime-Version:Content-Type:In-Reply-To:References:To:Cc:From: Subject:Message-Id; b=PNpIFzhHVfm4ixPunjQS81K+13lFtGqaLm9c30sNZ7kLYpM0Hnq/+YlfNMuVe6VkpSoDPJIE7MA9A33onSsdc+ETSX1UaTXAn6ZRgm49TD2I3F1KNISD8cfmO8HFx2GBSDdSC5CN081QG0/TNOnAOVN/eaUlvrOPxrAhZ0QHxJc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=fail smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=inNNDoO1; arc=none smtp.client-ip=118.26.132.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="inNNDoO1" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1762596667; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=As9vZLyUp565x8WqzAr/AY+rZQ4qn+Bn5PmSh9094bs=; b=inNNDoO1smvq5el0LoG1EUH1sZ7GLIdc0NENwM+jbP1AtMwFzgaLgj21+TGF3XrpYv2fnk mQqSbpq9ea7HwQcZcqdic0Oji58PCbaIP9Z8lzNxdIkyNls6yZxqiIVQYf9GQrl/EpBlqx 9h8xw37zFOaSWm/PPom2I4pwt2pNT+LfsrKtFAGCDfZQU8dXfLX/HHs6ZOcRKcio/Ii0Ef XO3cOXXjj4LPFjuVrLoJ4AS00YiyVuFHPr94h0FpevVxoYfbo5Tye9NFxorbF5AWv4m4MG Wt1jHA3oWR8NJDHk2/3nWb2nkyHqs9VcLeeuNGOLq+hoK5ZjCdXnS5lTKZdCPg== Date: Sat, 8 Nov 2025 18:11:03 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Lms-Return-Path: Content-Type: text/plain; charset=UTF-8 Reply-To: yukuai@fnnas.com X-Original-From: Yu Kuai User-Agent: Mozilla Thunderbird In-Reply-To: <20251106115935.2148714-5-linan666@huaweicloud.com> References: <20251106115935.2148714-1-linan666@huaweicloud.com> <20251106115935.2148714-5-linan666@huaweicloud.com> To: , , , Cc: , , , , , , From: "Yu Kuai" Subject: Re: [PATCH v2 04/11] md/raid1,raid10: support narrow_write_error when badblocks is disabled Message-Id: Received: from [192.168.1.104] ([39.182.0.168]) by smtp.feishu.cn with ESMTPS; Sat, 08 Nov 2025 18:11:04 +0800 =E5=9C=A8 2025/11/6 19:59, linan666@huaweicloud.com =E5=86=99=E9=81=93: > When badblocks.shift < 0 (badblocks disabled), narrow_write_error() > return false, preventing write error handling. Since narrow_write_error() > only splits IO into smaller sizes and re-submits, it can work with > badblocks disabled. > > Adjust to use the logical block size for block_sectors when badblocks is > disabled, allowing narrow_write_error() to function in this case. > > Suggested-by: Kenta Akagi > Signed-off-by: Li Nan > --- > drivers/md/raid1.c | 8 ++++---- > drivers/md/raid10.c | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) LGTM Reviewed-by: Yu Kuai