Re: [PATCH 14/15] soc: qcom-geni-se: add more symbol definitions

Konrad Dybcio
2022-11-18T13:37:51Z

On 18/11/2022 13:25, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The following symbols will be used when adding support for SE DMA in
> the qcom geni serial driver.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
You might have added them along with the new users, but still:

Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
> include/linux/qcom-geni-se.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/linux/qcom-geni-se.h b/include/linux/qcom-geni-se.h
> index f5672785c0c4..400213daa461 100644
> --- a/include/linux/qcom-geni-se.h
> +++ b/include/linux/qcom-geni-se.h
> @@ -103,6 +103,7 @@ struct geni_se {
> #define SE_DMA_TX_FSM_RST 0xc58
> #define SE_DMA_RX_IRQ_STAT 0xd40
> #define SE_DMA_RX_IRQ_CLR 0xd44
> +#define SE_DMA_RX_LEN_IN 0xd54
> #define SE_DMA_RX_FSM_RST 0xd58
> #define SE_HW_PARAM_0 0xe24
> #define SE_HW_PARAM_1 0xe28
> @@ -235,6 +236,8 @@ struct geni_se {
> #define RX_SBE BIT(2)
> #define RX_RESET_DONE BIT(3)
> #define RX_FLUSH_DONE BIT(4)
> +#define RX_DMA_PARITY_ERR BIT(5)
> +#define RX_DMA_BREAK GENMASK(8, 7)
> #define RX_GENI_GP_IRQ GENMASK(10, 5)
> #define RX_GENI_CANCEL_IRQ BIT(11)
> #define RX_GENI_GP_IRQ_EXT GENMASK(13, 12)