From: David Hildenbrand <david@redhat.com>
To: Oscar Salvador <osalvador@suse.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Michal Hocko <mhocko@kernel.org>,
Muchun Song <songmuchun@bytedance.com>,
Mike Kravetz <mike.kravetz@oracle.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Anshuman Khandual <anshuman.khandual@arm.com>
Subject: Re: [PATCH v4 0/4] Make alloc_contig_range handle Hugetlb pages
Date: Mon, 15 Mar 2021 11:28:56 +0100 [thread overview]
Message-ID: <a6b47162-d975-afef-473f-dccb677fefe6@redhat.com> (raw)
In-Reply-To: <20210315102740.GB25101@linux>
On 15.03.21 11:27, Oscar Salvador wrote:
> On Mon, Mar 15, 2021 at 10:06:40AM +0100, David Hildenbrand wrote:
>>
>> BTW, I stumbled yesterday over
>>
>> alloc_contig_pages()->pfn_range_valid_contig():
>>
>> if (page_count(page) > 0)
>> rerurn false;
>> if (PageHuge(page))
>> return false;
>>
>> As used by memtrace and for gigantic pages. We can now
>>
>> a) Drop these check completely, as it's best-effort only and racy.
>> alloc_contig_pages()/alloc_contig_range() will handle it properly.
>>
>> b) Similarly, check for gigantic pages and/or movability/migratability.
>>
>> Dropping both checks might be the right thing to do: might significantly
>> increase allocation chances -- as we actually end up migrating busy pages
>> ...
>
> Oh, sorry David, my mail client tricked me and I did not see this till now.
>
> I will have a look, but I would like to collect some more feedback from all
> pieces before going any further and write a new version.
> Vlastimil patch#1 and patch#2 and he was ok with them, but let see what others
> think as well.
Planning on having a detailed look at the patches. Fairly busy though
... :(
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-03-15 10:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 15:08 [PATCH v4 0/4] Make alloc_contig_range handle Hugetlb pages Oscar Salvador
2021-03-10 15:08 ` [PATCH v4 1/4] mm,page_alloc: Bail out earlier on -ENOMEM in alloc_contig_migrate_range Oscar Salvador
2021-03-15 11:00 ` Vlastimil Babka
2021-03-15 11:10 ` David Hildenbrand
2021-03-10 15:08 ` [PATCH v4 2/4] mm,compaction: Let isolate_migratepages_{range,block} return error codes Oscar Salvador
2021-03-15 11:03 ` Vlastimil Babka
2021-03-10 15:08 ` [PATCH v4 3/4] mm: Make alloc_contig_range handle free hugetlb pages Oscar Salvador
2021-03-10 15:08 ` [PATCH v4 4/4] mm: Make alloc_contig_range handle in-use " Oscar Salvador
2021-03-15 9:06 ` [PATCH v4 0/4] Make alloc_contig_range handle Hugetlb pages David Hildenbrand
2021-03-15 10:27 ` Oscar Salvador
2021-03-15 10:28 ` David Hildenbrand [this message]
2021-03-17 9:43 ` Oscar Salvador
2021-03-17 9:48 ` David Hildenbrand
2021-03-17 10:05 ` Oscar Salvador
2021-03-17 10:06 ` Oscar Salvador
2021-03-17 10:07 ` David Hildenbrand
2021-03-15 10:23 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b47162-d975-afef-473f-dccb677fefe6@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=osalvador@suse.de \
--cc=songmuchun@bytedance.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox