From: Wen Yang <wenyang@linux.alibaba.com>
To: Julia Lawall <julia.lawall@inria.fr>
Cc: Gilles Muller <Gilles.Muller@lip6.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Michal Marek <michal.lkml@markovi.net>,
Matthias Maennich <maennich@google.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thomas Gleixner <tglx@linutronix.de>,
cocci@systeme.lip6.fr, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls
Date: Fri, 10 Jan 2020 21:11:08 +0800 [thread overview]
Message-ID: <a6d58a19-c49d-f72e-9576-3ca64ffd6320@linux.alibaba.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2001071823060.3004@hadrien>
On 2020/1/8 1:25 上午, Julia Lawall wrote:
>> +@depends on context@
>> +expression f;
>> +long l;
>> +unsigned long ul;
>> +u64 ul64;
>> +s64 sl64;
>> +
>> +@@
>> +(
>> +* do_div(f, l);
>> +|
>> +* do_div(f, ul);
>> +|
>> +* do_div(f, ul64);
>> +|
>> +* do_div(f, sl64);
>> +)
>
> This part is not really ideal. For the reports, you filter for the
> constants, but here you don't do anything. You can put some python code
> in the matching of the metavariables:
>
> unsigned long ul : script:python() { whatever you want to check on ul };
>
> Then it will only match if the condition is satisfied.
>
> julia
>
OK, thank you very much.
We'll fix it soon.
--
Best Wishes,
Wen
next prev parent reply other threads:[~2020-01-10 13:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 17:02 [PATCH v2] coccinelle: semantic patch to check for inappropriate do_div() calls Wen Yang
2020-01-07 17:25 ` Julia Lawall
2020-01-10 13:11 ` Wen Yang [this message]
2020-01-09 10:35 ` Markus Elfring
2020-01-09 10:41 ` Julia Lawall
2020-01-09 12:00 ` [v2] " Markus Elfring
2020-01-09 12:04 ` Julia Lawall
2020-01-09 12:14 ` Markus Elfring
2020-01-09 12:17 ` Julia Lawall
2020-01-09 12:21 ` Markus Elfring
2020-01-10 10:00 ` [PATCH v2] " Markus Elfring
2020-01-10 12:34 ` Julia Lawall
2020-01-10 15:46 ` [v2] coccinelle: semantic code search " Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d58a19-c49d-f72e-9576-3ca64ffd6320@linux.alibaba.com \
--to=wenyang@linux.alibaba.com \
--cc=Gilles.Muller@lip6.fr \
--cc=cocci@systeme.lip6.fr \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=michal.lkml@markovi.net \
--cc=nicolas.palix@imag.fr \
--cc=tglx@linutronix.de \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox