From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-178.mta1.migadu.com (out-178.mta1.migadu.com [95.215.58.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 854CC22FE0E for ; Tue, 14 Apr 2026 13:57:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776175034; cv=none; b=Si2Dy/SWal7gallNSwNq3AprFAWaA5xkIVUym+2I7En611IIdl5j/c+VwT11vAMFAUZVwntqJo3w6u2QazhYgtjslKPnoS61fMyZy9m3AbapjTHpuzVuo3Mq9uuhJPGSMyRdJfNQbxw1G09EXSJtEJA91wXAXZEgPcePMWu/ayo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776175034; c=relaxed/simple; bh=WdrZQIlF6dqAmWcBYZjdasD1nN4EJsN+jX8ww4GW1rk=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=joshnXOjKkAjLtzGoMMS4GyiRUsuMuh3ynbCyt5W5LN+0BB5Tiyhnt8vR9yJte2QC4iBNoKTm7AExhlQo5NM4+iOxUGMqahAdbSL1mONkq3cNsrDAjGU1+yTUh3WkyhPMFTWTXpuLdLIcpAUPQFjntoAkx2GvrO79TtipbW3UYY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=Gs7/E/on; arc=none smtp.client-ip=95.215.58.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="Gs7/E/on" Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1776175029; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nq/O3jFcXuGXkm/xRXy/eNIPKG9sl6o8TkqLD7aFLzo=; b=Gs7/E/onVm21TQ0DizrQJ9kIkWd1JeeOPsROBicpQwN78nToieX1UfoM6JJaew1mL7dmdH JczeM3DTeg0OSOqm/FYoJc1a7CDid6vFFWuKgcu9uce5DQ+yQrafRRzC8tvgY9S7Ormbod n6rNEp+SoOpLs139FL/7tEGykOS8k6Y= Subject: Re: [PATCH bpf-next 1/2] bpf: tcp: Reject TCP_NODELAY from BPF hdr opt callbacks X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: KaFai Wan To: edumazet@google.com, ncardwell@google.com, kuniyu@google.com, davem@davemloft.net, dsahern@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, martin.lau@linux.dev, eddyz87@gmail.com, memxor@gmail.com, song@kernel.org, yonghong.song@linux.dev, jolsa@kernel.org, shuah@kernel.org, sdf@fomichev.me, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-kselftest@vger.kernel.org Cc: Quan Sun <2022090917019@std.uestc.edu.cn>, Yinhao Hu , Kaiyan Mei Date: Tue, 14 Apr 2026 21:56:53 +0800 In-Reply-To: <20260414112310.1285783-2-kafai.wan@linux.dev> References: <20260414112310.1285783-1-kafai.wan@linux.dev> <20260414112310.1285783-2-kafai.wan@linux.dev> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT On Tue, 2026-04-14 at 19:23 +0800, KaFai Wan wrote: AI is right and I'm late for the issue. Please ignore this. Sorry for the n= oise. > A BPF_SOCK_OPS program can enable > BPF_SOCK_OPS_WRITE_HDR_OPT_CB_FLAG and then call > bpf_setsockopt(TCP_NODELAY) from BPF_SOCK_OPS_HDR_OPT_LEN_CB. >=20 > That reaches __tcp_sock_set_nodelay(), which may call > tcp_push_pending_frames(). The transmit path then computes TCP > options again, re-enters bpf_skops_hdr_opt_len(), and invokes the > same BPF callback recursively. This can loop until the kernel > stack overflows. >=20 > TCP_NODELAY is not safe from the header option callback context. > Reject it with -EOPNOTSUPP when TCP header option callbacks are > enabled on the socket, so the callback cannot recurse back into > tcp_push_pending_frames() through do_tcp_setsockopt(). >=20 > Reported-by: Quan Sun <2022090917019@std.uestc.edu.cn> > Reported-by: Yinhao Hu > Reported-by: Kaiyan Mei > Closes: https://lore.kernel.org/bpf/d1d523c9-6901-4454-a183-94462b8f3e4e@= std.uestc.edu.cn/ > Fixes: 7e41df5dbba2 ("bpf: Add a few optnames to bpf_setsockopt") > Signed-off-by: KaFai Wan > --- > =C2=A0net/ipv4/tcp.c | 5 ++++- > =C2=A01 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/net/ipv4/tcp.c b/net/ipv4/tcp.c > index 202a4e57a218..7ac4c98be19d 100644 > --- a/net/ipv4/tcp.c > +++ b/net/ipv4/tcp.c > @@ -4004,7 +4004,10 @@ int do_tcp_setsockopt(struct sock *sk, int level, = int optname, > =C2=A0 > =C2=A0 switch (optname) { > =C2=A0 case TCP_NODELAY: > - __tcp_sock_set_nodelay(sk, val); > + if (val && BPF_SOCK_OPS_TEST_FLAG(tp, BPF_SOCK_OPS_WRITE_HDR_OPT_CB_FL= AG)) > + err =3D -EOPNOTSUPP; > + else > + __tcp_sock_set_nodelay(sk, val); > =C2=A0 break; > =C2=A0 > =C2=A0 case TCP_THIN_LINEAR_TIMEOUTS: --=20 Thanks, KaFai