Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

Vojtech Pavlik
2005-02-04T13:45:22Z

On Fri, Feb 04, 2005 at 08:17:43AM -0500, Stephen Evanchik wrote:
> On Fri, 4 Feb 2005 07:35:20 +0100, Vojtech Pavlik <vojtech@suse.cz> wrote:
> > > > /*
> > > > + * Try to initialize the IBM TrackPoint
> > > > + */
> > > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) {
> > > > + psmouse->vendor = "IBM";
> > > > + psmouse->name = "TrackPoint";
> > > > +
> > > > + return PSMOUSE_PS2;
> > >
> > > Why PSMOUSE_PS2? Reconnect will surely not like it.
> >
> > Indeed. IIRC this patch killed wheel mouse detection in ubuntu.
>
> Earlier versions of the patch didn't disable the device while probing
> so events could be interpreted as the magic ID of a TrackPoint. It now
> resets and disables the PS/2 device before detection but not after a
> detect failure.

Since we fixed libps2, this shouldn't happen anymore, as long as the
BIOS doesn't inject an endless stream of data from an USB mouse.

> I'll clean that up so its more sensible.

Thanks.

--
Vojtech Pavlik
SuSE Labs, SuSE CR