Re: [PATCH 2.6.11-rc3] IBM Trackpoint support

Vojtech Pavlik
2005-02-04T06:55:11Z

On Fri, Feb 04, 2005 at 01:52:39AM -0500, Dmitry Torokhov wrote:
> On Friday 04 February 2005 01:35, Vojtech Pavlik wrote:
> > On Thu, Feb 03, 2005 at 07:34:16PM -0500, Dmitry Torokhov wrote:
> > > On Thursday 03 February 2005 17:43, Stephen Evanchik wrote:
> > > > Vojtech,
> > > >
> > > > Here is a patch that exposes the IBM TrackPoint's extended properties
> > > > as well as scroll wheel emulation.
> > > >
> > > >
> > >
> > > Hi,
> > >
> > > Very nice although I have a couple of comments.
> > >
> > > > /*
> > > > + * Try to initialize the IBM TrackPoint
> > > > + */
> > > > + if (max_proto > PSMOUSE_PS2 && trackpoint_init(psmouse) == 0) {
> > > > + psmouse->vendor = "IBM";
> > > > + psmouse->name = "TrackPoint";
> > > > +
> > > > + return PSMOUSE_PS2;
> > >
> > > Why PSMOUSE_PS2? Reconnect will surely not like it.
> >
> > Indeed. IIRC this patch killed wheel mouse detection in ubuntu.
> >
>
> We may need yet another psmouse_reset after unsuccessful test.

We probably should do one after every test for isolation. It's not that
big a problem now that we do the probing from a thread.

--
Vojtech Pavlik
SuSE Labs, SuSE CR