From: Krzysztof Kozlowski <krzk@kernel.org>
To: Qin Jian <qinjian@cqplus1.com>
Cc: robh+dt@kernel.org, mturquette@baylibre.com, sboyd@kernel.org,
tglx@linutronix.de, maz@kernel.org, p.zabel@pengutronix.de,
linux@armlinux.org.uk, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver
Date: Tue, 22 Mar 2022 12:04:42 +0100 [thread overview]
Message-ID: <a7194fbf-8423-9b49-1443-68dd33e23783@kernel.org> (raw)
In-Reply-To: <55db801055793f43678e902395913330ecb8fbbf.1647928316.git.qinjian@cqplus1.com>
On 22/03/2022 07:16, Qin Jian wrote:
> Add documentation to describe Sunplus SP7021 reset driver bindings.
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Qin Jian <qinjian@cqplus1.com>
> ---
> .../bindings/reset/sunplus,reset.yaml | 38 ++++++++
> MAINTAINERS | 2 +
> include/dt-bindings/reset/sp-sp7021.h | 97 +++++++++++++++++++
> 3 files changed, 137 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/reset/sunplus,reset.yaml
> create mode 100644 include/dt-bindings/reset/sp-sp7021.h
>
> diff --git a/Documentation/devicetree/bindings/reset/sunplus,reset.yaml b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml
> new file mode 100644
> index 000000000..c083c821f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/sunplus,reset.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +# Copyright (C) Sunplus Co., Ltd. 2021
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/reset/sunplus,reset.yaml#"
> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Sunplus SoC Reset Controller
> +
> +maintainers:
> + - Qin Jian <qinjian@cqplus1.com>
> +
> +properties:
> + compatible:
> + const: sunplus,sp7021-reset
> +
> + "#reset-cells":
> + const: 1
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - "#reset-cells"
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + rstc: reset@9c000054 {
> + compatible = "sunplus,sp7021-reset";
> + #reset-cells = <1>;
> + reg = <0x9c000054 0x28>;
I asked you to put the reg after compatible in all DTS code and
examples. If you do not agree with a comment, please respond. Ignoring
it is not cooperative.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-22 11:04 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-22 6:16 [PATCH v11 0/9] Add Sunplus SP7021 SoC Support Qin Jian
2022-03-22 6:16 ` [PATCH v11 1/9] dt-bindings: arm: sunplus: Add bindings for Sunplus SP7021 SoC boards Qin Jian
2022-03-22 6:16 ` [PATCH v11 2/9] dt-bindings: reset: Add bindings for SP7021 reset driver Qin Jian
2022-03-22 11:04 ` Krzysztof Kozlowski [this message]
2022-03-23 1:54 ` qinjian[覃健]
2022-03-23 8:37 ` Krzysztof Kozlowski
2022-03-23 8:44 ` qinjian[覃健]
2022-03-22 6:16 ` [PATCH v11 3/9] reset: Add Sunplus " Qin Jian
2022-03-22 6:16 ` [PATCH v11 4/9] dt-bindings: clock: Add bindings for SP7021 clock driver Qin Jian
2022-03-22 11:02 ` Krzysztof Kozlowski
2022-03-22 6:16 ` [PATCH v11 5/9] clk: Add Sunplus " Qin Jian
2022-03-22 6:16 ` [PATCH v11 6/9] dt-bindings: interrupt-controller: Add bindings for SP7021 interrupt controller Qin Jian
2022-03-22 6:16 ` [PATCH v11 7/9] irqchip: Add Sunplus SP7021 interrupt controller driver Qin Jian
2022-03-22 6:16 ` [PATCH v11 8/9] ARM: sunplus: Add initial support for Sunplus SP7021 SoC Qin Jian
2022-03-22 6:17 ` [PATCH v11 9/9] ARM: sp7021_defconfig: Add Sunplus SP7021 defconfig Qin Jian
2022-03-22 10:19 ` Arnd Bergmann
2022-03-23 1:41 ` qinjian[覃健]
2022-03-23 8:20 ` Arnd Bergmann
2022-03-23 8:45 ` qinjian[覃健]
2022-03-22 10:56 ` [PATCH v11 0/9] Add Sunplus SP7021 SoC Support Sudeep Holla
2022-03-23 2:40 ` qinjian[覃健]
2022-03-23 11:15 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7194fbf-8423-9b49-1443-68dd33e23783@kernel.org \
--to=krzk@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maz@kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=qinjian@cqplus1.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox