From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0314C433F5 for ; Wed, 11 May 2022 14:03:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244316AbiEKODH (ORCPT ); Wed, 11 May 2022 10:03:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33774 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S244312AbiEKODE (ORCPT ); Wed, 11 May 2022 10:03:04 -0400 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9A7E51133 for ; Wed, 11 May 2022 07:03:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1652277783; x=1683813783; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=T8ct8MaxuAq9oRdiITvm+NoWseyVHyvo8hOAG6x7BvU=; b=XFyre/ztqqx0RqCCJ1C+9WzDdZkzCsMlSVzUeZqYD7KIcdMxL6Jmog46 zVQFd98xzM144FzKyek08/v+nnGJnZcrZJEty4mC3yHucM+KE6G0KOMu+ 8/RPNHUhvaXdqLDnbaQDiXljl3nmSnSiJmdQsPAOO/LYFJInz2PMFGSEd 6Ezsqrqlsf5KltDqvUQEMhHfpyENz/AIRAf/xLpW7/IFKN+TPZWxzXFGV 5Q0xe+RaqvcPqTcLsM7b6enBrDxTz+BI5xiGoC/wncI+6xrehZM0oZmZy JzuEXj5PXQ2wFuFJ/xL45F0k8EPs2n673sGWRji0WwjQDLYrDnOIyP0xL Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10343"; a="267293026" X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="267293026" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 07:03:01 -0700 X-IronPort-AV: E=Sophos;i="5.91,217,1647327600"; d="scan'208";a="658171262" Received: from naydenov-mobl.amr.corp.intel.com (HELO [10.209.48.198]) ([10.209.48.198]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 May 2022 07:02:59 -0700 Message-ID: Date: Wed, 11 May 2022 09:02:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.5.0 Subject: Re: [PATCH] [v2] ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio Content-Language: en-US To: Terry Chen Cc: alsa-devel@alsa-project.org, cezary.rojewski@intel.com, liam.r.girdwood@linux.intel.com, yang.jie@linux.intel.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, brent.lu@intel.com, cujomalainey@chromium.org, Sean Paul , casey.g.bowman@intel.com, Mark Hsieh , vamshi.krishna.gopal@intel.com, Mac Chiang , kai.vehmanen@linux.intel.com, linux-kernel@vger.kernel.org References: <20220510104829.1466968-1-terry_chen@wistron.corp-partner.google.com> <190c9add-7fa4-8e76-bfcb-43d30f22f8d9@linux.intel.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/22 01:33, Terry Chen wrote: > Hi Pierre-Louis > >> @@ -522,6 +578,14 @@ static struct snd_soc_dai_link *sof_card_dai_links_create(struct device *dev, >>                               goto devm_err; >>                       } >>                       break; >> +             case LINK_BT: >> +                     ret = create_bt_offload_dai_links(dev, links, cpus, &id, ssp_bt); >> +                     if (ret < 0) { >> +                             dev_err(dev, "fail to create bt offload dai links, ret %d\n", >> +                                     ret); > > For this point, we just follow Intel member to write for this coding > style. The other component also was the same style. the magic of copy-paste, eh? Please update this, thanks. > > @@ -384,6 +384,14 @@ struct snd_soc_acpi_mach > snd_soc_acpi_intel_adl_machines[] = { > >               .sof_fw_filename = "sof-adl.ri", > >               .sof_tplg_filename = "sof-adl-cs35l41.tplg", > >       }, > > +     { > > +             .id = "10134242", > > +             .drv_name = "adl_mx98360a_cs4242", > > +             .machine_quirk = snd_soc_acpi_codec_list, > > +             .quirk_data = &adl_max98360a_amp, > > +             .sof_fw_filename = "sof-adl.ri", > > This  also was the same style with others. No, it's not a matter of style but rather that this field was *REMOVED*, this cannot possibly compile. see commit a6264056b39ee ("ASoC: soc-acpi: remove sof_fw_filename ") If you had submitted this patch through the SOF tree, you would have seen a compilation error. > > > +             .sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg", > > Why would you refer to a topology that uses a different codec? > > >  Because Intel college use the same naming style for the same audio codec. It's bad practice to use the same topology name for different platforms based on different codecs. One evolution of the topology would impact an unrelated platform. Please use a symlink or duplicate the topology with a different name, this is not future-proof and will be problematic for releases.