From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B66072BE7A7 for ; Fri, 11 Apr 2025 10:01:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744365715; cv=none; b=n0RkvdJ1ItITpSHVnJPDU7A43qotEUS7YpjgD2ZpHzt7VXah+aYidWsMe+jTricvYX+oerSO07hIrlg+6XMEYDCCK/9pXc/sp2hbpelx5oRq/wDvgNdHl8AahBFRwfiWgz68981ojkjD7JabQh0Af1KgcDnpNiP/hzj3SiKi3Cs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744365715; c=relaxed/simple; bh=wgUljy19hnRNr8ZDImG9+dtUI37oYH5FJgi3lFZ7DlA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OpasIZwRBazPuH+o4fV9H4XarBO9JMDggT1nu5GoE00/0p7J3GPp10MRHkUsFag8sEH/+tNa/QcdamxDqbwyA2rwLdvOwqRRgwbfcy+96B4a+kKvh/5FwDL+CY4seoiq6wZbgwx345eCgdDG5n/symqwfEBM3vGB0wDTf7gW+YI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=hhrN2Tf7; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="hhrN2Tf7" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53B5cqda030704 for ; Fri, 11 Apr 2025 10:01:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= HSoTVp2S/VYJN3XymStKcEZsPCfLWwow1kwx9gRcxUI=; b=hhrN2Tf7aScDk6ps pMvAl4oBoWH40jHKjqP1ChoRZQ3uViR15N66SuRrXL3Ts/26Lc8MMa64laVcr+ta gSHUzTvh7Asr1TT7VnmTTV/oJF902IzkWZUnrZWvBLnR1lClBD1VSSqypQ7xhG88 os30YWY+5YRu0MmfAqG7ZORUxQh1oMgZvIU43txwW+XpNzGKiuamegOdLm3xZgMH SJYcRRR/OrUYAfTFcL5ltBcCdU1xq938VvPjgxVkOUN3ZINX5Vo8vxfxk8EdRnYv M9RshCqoMqf0DjZ9AzqJbIisjYAnGmI2z2weXHts6qmsAzgYdla0I1bfAQNjj3aO k+pdvg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45twftssgq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Fri, 11 Apr 2025 10:01:52 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-7c54734292aso46544785a.2 for ; Fri, 11 Apr 2025 03:01:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744365711; x=1744970511; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HSoTVp2S/VYJN3XymStKcEZsPCfLWwow1kwx9gRcxUI=; b=mP0XLnXHl3Nqbbcv7LUYF5r+7pnxKpV8iWaOsFE/duUEeDlk2zqB983+6+J/7eRCrk B8CeOta0AiHSOygbyTRvHKYBMznq+KfDHBCefkINLuOqdYreJaW6bKfo6gZDjWoBJ676 vd3QpQtU0yfsjDP1B0FjT6IPQP/eVXhWk9ovpAPFbU3e5KDLTmEXbq9pX6cDB3LsSkTw qkrLENTGN1u991+Jx4APKhYJHiB9s8RZ7ysHOWck3RLQuCx55/7GRDE8k8X617PGzFFt Zclk30ynz0MgcFzr3H/+PQExJQo99I0Up/vVw9YPAUnpROuohS34GYFw7qZH78jR9XWg iHbA== X-Forwarded-Encrypted: i=1; AJvYcCX92mGJxR/SY0m1I9pbcSwyxr649V/s/80/7/XfwJ9nkmRnhUIyMJhHJwYVf1zWMxlNTzIRqcZvC1F+7KE=@vger.kernel.org X-Gm-Message-State: AOJu0YwZGrZzrkcHiBORtuNbVwsLlKNU6lpYcpYnllAk1eBtQ2Frjzn5 uOGWvLZWeTrkWBBoRkfGQ0vsQdlhlE36THx8al/lN2IgqSxNG03gg/80ecdXatlclR7Ud4uGyVB SsRNXz+HxdY+FBQYClq0IaAQij0dVLAQRLbLnzNQF9sIyazvrQAM501OGkeNaZt4= X-Gm-Gg: ASbGncuXcirsEybSJDnBScWGf6myZ1sWyCsDjvzRhFX5FVMiuB8txHELJu0x5EuNXzK vOCOY5egOFKltX5i3mtg/8X1k4AY+7Z4WFBVo8WUbnW91SpvKD3kjxIV41g0DaWz2zGOW6Zia+3 Fk3VCrZij6qOZs82mcQGyNuriSIeL5SLd4dt50BrdpQhzsxx0ncS7AHLVyP4VvBDvyK58owKjoy aB3NB/rr/uYhapyN5Uv7drC63ouV/gd2pnJMCZZZpJcDNtF1f1n5zi4+uO5y7TWNnHjuMhwFSbI YW0xT7onJdgAeYpMOUBwjcL2ykppSpUGrIT7xkyWMpZhe+1nCP0gwc7HcnvcxKA6Fg== X-Received: by 2002:a05:620a:2806:b0:7c5:8f37:5eb8 with SMTP id af79cd13be357-7c7af1ccb80mr103665385a.12.1744365711395; Fri, 11 Apr 2025 03:01:51 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGofGcepn/RGsMZLKQQY5oS/V52iksVU2RCQiBQQZDbCSNXMEaGLEUkxdxGG5ZVFaRTxXOV8w== X-Received: by 2002:a05:620a:2806:b0:7c5:8f37:5eb8 with SMTP id af79cd13be357-7c7af1ccb80mr103663685a.12.1744365710984; Fri, 11 Apr 2025 03:01:50 -0700 (PDT) Received: from [192.168.65.90] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-acaa1be8eebsm409211766b.40.2025.04.11.03.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Apr 2025 03:01:50 -0700 (PDT) Message-ID: Date: Fri, 11 Apr 2025 12:01:48 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] soc: qcom: socinfo: Add support for new fields in revision 22 To: Mukesh Ojha , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250411095025.4067964-1-mukesh.ojha@oss.qualcomm.com> <20250411095025.4067964-3-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20250411095025.4067964-3-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=B5+50PtM c=1 sm=1 tr=0 ts=67f8e890 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=pPKmUzXJjBbFbCUHgUMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-GUID: rnS_m2N7E6TxriiU5Y6pwwCukah-EQVh X-Proofpoint-ORIG-GUID: rnS_m2N7E6TxriiU5Y6pwwCukah-EQVh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-11_03,2025-04-10_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=999 suspectscore=0 malwarescore=0 bulkscore=0 phishscore=0 spamscore=0 priorityscore=1501 adultscore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504110062 On 4/11/25 11:50 AM, Mukesh Ojha wrote: > Add the ncluster_cores_array_offset field with socinfo structure > revision 22 which specifies no of cores present in each cluster. > > Signed-off-by: Mukesh Ojha > --- So with all three of your patches, you neither introduce a user for them, nor even expose them in debugfs. Please definitely add the latter, and let's talk about the former. What's 'subpart feture'? How should we interpret the value added in patch 1? Does it expose the higher temperature threshold in degrees, or do we need to add some hardcoded variants for each platform separately? Konrad