From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C55FA43635C for ; Thu, 30 Apr 2026 15:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777563852; cv=none; b=R2OSfI4BceqaSQtPSP+eel5amIJgtJIu7MbHkMBeOqmct8oiSKZnHLsBq59Yo1OibU/hv9aY90YM+5hIQVMtZ0mBFLndrswR5JzjADIC+sj5l8BXEgshT94IlVbFzVd6T9XzIAD4j9zF9vDglOgDRYiHP9E6o6LXT9ZvQnjpmM4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777563852; c=relaxed/simple; bh=nhUUkVi9/hcYpl+bQ0fHNNneX3Eu22Xic+NtqQ3E/qw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=CUR5ajSc9UfrmbmSpmLok37itXntbmpa+1pvYYmPPkzGjAGCmTLIhdsalH/ROIgd8UhBZ9ixl907GLlh5OmcqcI37Pt3auto29tSSB0FJ9IKIWbkzM7jF47cXcpn/vmNuok2KJxqnyOFWTl3ca1MdG1zZ5wwEJcFs2Gb+vcMwHA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=m1q/nkbn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V8U+AfEm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="m1q/nkbn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V8U+AfEm" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63UBk6sq1820434 for ; Thu, 30 Apr 2026 15:44:08 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 17t3T+XOa+UMBrL9L1bRnwu0sMA5ZJW1jZ+/PIyf8Fw=; b=m1q/nkbnbEl3h9ZS QOhSS/CwDIZqfdQq4Z/bKLWv4ePXtO69SrX/Ohi1Z+Dt/YHTCpjHRimvenu5S434 ZlDYJACOyv10EKlPFslVr46Oypyh8QnWw7VyVcueZdPSLSGEQoS7BEl57tf8IxGS 9aRwpFA/LSPy6+glSyxK/xjx+PeGl2mnAVHL1bP5SjkX94rD9UIBkcrYYpmOwDVi ts67b5eQTnbc4PjbukcrB1SGTyRRh8X3b/uMzotv1qzAmOpeRui/2pbfKeg6LWpc W01+r/GaIApHdBAwWKXntiZCZ/88SUxirMMpfBfrqf3OPlRCxjAK9xcz8KNmfHek toKWlA== Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dv6ges4m5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 30 Apr 2026 15:44:07 +0000 (GMT) Received: by mail-vs1-f71.google.com with SMTP id ada2fe7eead31-5ff9e60dd65so102475137.3 for ; Thu, 30 Apr 2026 08:44:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777563847; x=1778168647; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=17t3T+XOa+UMBrL9L1bRnwu0sMA5ZJW1jZ+/PIyf8Fw=; b=V8U+AfEmIe5bFWNygVNsnyA0x6+tCg7LPKmcZsPBsvszzpnDs4HzjBMD45Jb75OlzT M2G1pyRzyUvGGtftYY2q89CyP+QbC+RkPIuBqqsoiXetaQlw8krNworxEDFnHpIDFMvG unZhGsLV1tArJlVInZQH84pgrGVUNdafh6dFrwdjn1nbNnaHboTtwiLFtXREuA9WGvUT FgI+DqtP/fVTYPs5EX7IGGnbKB7A+3RF6NLLY6mZNChQieBbWaq51jO8/dRRH8dfEB1s RZvmz9dN0sb9gJ2Udl1mxdIdj1dcYm2VDBb28VVELCGxww+LKAPeW/+CuHX5JZ5owmi2 KdQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777563847; x=1778168647; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=17t3T+XOa+UMBrL9L1bRnwu0sMA5ZJW1jZ+/PIyf8Fw=; b=NQba5hko88uPq4CJiIZhFjVq75XE0FipoWiRLCLSUfY4pmfzUJ2T/A5JVndwv1iTx+ nTpGQgSd5KOQO7abPmXuUj4H54lIhgGWh3oM5h03ksTYgLm8zXAFWCszkYQjCaNUr+pO xAUJ75eHQiOmI5b5euS3+jjYms4+TTdQen/lkCK9m09MxZ0uo8KK8ZYYOFmAJLUApno1 +J2Go/SisbpejJQixDlwMXoQeDdSbZXmSBxB/1E3UicobSV5pBlvKIkxqq1JN+Ad7h5E Sf4LfHNprSsu+fjpEJ8kjYEaZTIW6a6GtZkapVPFSPvV79LBVu3EbC5343GeZqATcFM8 K/AQ== X-Forwarded-Encrypted: i=1; AFNElJ8WUdiB/FxkrESBryxLOK1wqN2yFXsBm+FJdTO0jdFfOXeVq0GwIYks4mUAQofuAYKTBi8ZtuNQWn2S5oI=@vger.kernel.org X-Gm-Message-State: AOJu0Yw2y4729J3fnP2jCWc3m27zFc9NMZZ/O+6WaA3Ctgiw/H3+Sxlx F+oOm4Srnzdth1M0uQRMnRUXy0nQ7ztP08wp1BY2DJl5sorA0GhIvyfTSqZ4PJVIfOUn9bwug+m vKYsPomfOM13L46iY/Y+hDXEizXUU/m9mcqEBEuSwTMRIJkZl18Bj630FmnkgXNIlSVE= X-Gm-Gg: AeBDies70K1tbGjRJJ/kKMH7dfNqHoyDsw79SwHFBG1AQZgNYS2OrgSHbW5FNkUcUaG RLQ480L0WcBeU0q4/XFtgqdDwhfNDFhvUVv+fdJiueeWLzvG8T32mf/nKAT9iBaJlONy7pJttZF vYt7bnMb8ZAZlOGm0y7wHRjJt2/RL7edYFsqNN6ZGmGAGQ/4xdURMPaLiK+ac022EgBzF0yenAU u87WTr80wXG5hPJvBZKbGfYzarADMqkcpcUbyxWxEzyG7G33lEznMhU56DZX0I02cNOgL9ZeFpC PPvv9N7D35TQznAA5w9HgiGEkuepu6JlMnlDUbUUkZFtXJDs/Oq5y3XndLOouC7Arwzuokq+nBs 6kHZ6z1X33NgCALBmXpqMa/8VkwSF+ab1WRCMsp7Ro93BqLmf1dTZzgbyNJONVXFFZxYl0l5SBB 6XOFKaUip0xBwMiw== X-Received: by 2002:ac5:ce0d:0:b0:56a:9e65:3e30 with SMTP id 71dfb90a1353d-573c96f749amr640430e0c.3.1777563846746; Thu, 30 Apr 2026 08:44:06 -0700 (PDT) X-Received: by 2002:ac5:ce0d:0:b0:56a:9e65:3e30 with SMTP id 71dfb90a1353d-573c96f749amr640426e0c.3.1777563846217; Thu, 30 Apr 2026 08:44:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bbe6a64d4cbsm12589166b.16.2026.04.30.08.44.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2026 08:44:05 -0700 (PDT) Message-ID: Date: Thu, 30 Apr 2026 17:44:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/13] clk: qcom: clk-alpha-pll: Add support to skip PLL configuration To: Jagadeesh Kona , Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Michael Turquette , Stephen Boyd , Neil Armstrong , Lee Jones , Ajit Pandey , Imran Shaik , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Maulik Shah , Taniya Das References: <20260420-cesta-sm870-dispcc-v1-0-eb27d845df9c@oss.qualcomm.com> <20260420-cesta-sm870-dispcc-v1-7-eb27d845df9c@oss.qualcomm.com> <5vkpjjuq6vh2mr4lcq5cwqd4h5cbserf3n756d465kheuwl5fk@tu3amjwe5k57> <269bdec3-6340-4b27-9b38-3fc1dfc958c8@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=f6V4wuyM c=1 sm=1 tr=0 ts=69f378c7 cx=c_pps a=P2rfLEam3zuxRRdjJWA2cw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=C5MmyifQ20IcwxlzDtwA:9 a=0bXxn9q0MV6snEgNplNhOjQmxlI=:19 a=QEXdDO2ut3YA:10 a=ODZdjJIeia2B_SHc_B0f:22 X-Proofpoint-GUID: DR0drG-7Sp_20Z7tOY_2MdJkcGcpz0Ic X-Proofpoint-ORIG-GUID: DR0drG-7Sp_20Z7tOY_2MdJkcGcpz0Ic X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDMwMDE2MiBTYWx0ZWRfX+lfF/CoW6eBI 8SemJfQjscmt/X5RkjW2BeFzbQqvB7eA7CCKpQ0Wn18/CTmmaD1yghQn44yIXMtqZKm1AefVhGT mUuvRk3+rtqmCaTmbkkAdf0c67ZG2BAbjNAMkkaHRF0sHEHb1qi7pdgHjz8RQrhDcNfec5EMslI tFi13n8pmqzL2p9fmeX/rPinfEshTE+ZamcBbjHL6JcqM+iWAgNg4Gwk8s57e56EZI0vua8PGAx n5eWyMZ/cHafNHj0LstzG0yrKEskWfexEI/xbNeBXGBE8TReGS2MYnke+6083Fe71Ul1FBqQ11Q Mhah6C7mhQhOzbBmFrG28HN1oTVP2k8qhSTx8PwKL0PFRvK0ZYiq0jZ+ZviXnrsEZByBTDWALqe R6uJbbuu9IOXwvrs3CpFzKbTyByuj4goHp72ohMljWiXx8qwsNJs0fojmzSWxSxwOtxAaKX3cVl rbL4lwkgPyO+6yLAg+A== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-30_04,2026-04-30_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 malwarescore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604300162 On 4/28/26 7:22 PM, Jagadeesh Kona wrote: > > > On 4/23/2026 4:43 PM, Konrad Dybcio wrote: >> On 4/22/26 8:28 PM, Dmitry Baryshkov wrote: >>> On Mon, Apr 20, 2026 at 09:59:00PM +0530, Jagadeesh Kona wrote: >>>> Some PLLs are already configured as part of CRM(CESTA Resource >>>> manager) initialization. Add support to skip PLL reconfiguration >>>> for such PLLs that are already configured. >>>> >>>> Signed-off-by: Jagadeesh Kona >>>> --- >>>> drivers/clk/qcom/clk-alpha-pll.c | 8 +++++++- >>>> 1 file changed, 7 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/clk/qcom/clk-alpha-pll.c b/drivers/clk/qcom/clk-alpha-pll.c >>>> index 67fc97739d0d4c26aec0bac5d43d1b87d297bc6a..2f4ebf4d3884b92c981dbe0e67245704a88881ad 100644 >>>> --- a/drivers/clk/qcom/clk-alpha-pll.c >>>> +++ b/drivers/clk/qcom/clk-alpha-pll.c >>>> @@ -2332,7 +2332,7 @@ EXPORT_SYMBOL_GPL(clk_alpha_pll_zonda_ops); >>>> void clk_lucid_evo_pll_configure(struct clk_alpha_pll *pll, struct regmap *regmap, >>>> const struct alpha_pll_config *config) >>>> { >>>> - u32 lval = config->l; >>>> + u32 lval = config->l, regval; >>>> >>>> /* >>>> * If the bootloader left the PLL enabled it's likely that there are >>>> @@ -2343,6 +2343,12 @@ void clk_lucid_evo_pll_configure(struct clk_alpha_pll *pll, struct regmap *regma >>>> return; >>>> } >>>> >>>> + /* Return early if PLL is already configured */ >>>> + regmap_read(regmap, PLL_L_VAL(pll), ®val); >>>> + regval &= LUCID_EVO_PLL_L_VAL_MASK; >>>> + if (regval) >>>> + return; >>>> + >>> >>> Why is it being applied only to Lucid EVO PLLs? >> > > Thanks Dmitry and Konrad for your reviews. > > This is the function used to configure all Taycan PLLs, currently all the PLLs > configured during CESTA initialization belong to Taycan type only. I will recheck > if similar logic is required for any additional PLL types also. > > >> These clocks already have a an .is_enabled() callback, could that be >> treated as equivalent? >> > > We already have is_enabled check to avoid configuring PLL's that are already enabled. > There can be case where PLL is configured from bootloader but not enabled during bootup. > This check avoids re-configuring such PLLs that are already configured by bootloader but > not enabled. Okay, that was the missing piece. Is this a micro-optimization, or something highly necessary (for e.g. glitch-free display)? Konrad