From: ashwinc@codeaurora.org
To: mingo@redhat.com, "LKML" <linux-kernel@vger.kernel.org>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Arjan van de Ven" <arjan@linux.intel.com>
Subject: [RFC] [PATCH 1/1] Remove static debugfs path from parse-events
Date: Sun, 4 Oct 2009 15:49:34 -0700 (PDT) [thread overview]
Message-ID: <a751bdc6978478de6d10440e587a2cc7.squirrel@www.codeaurora.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
I was working on getting timechart running and noticed that it wouldn't
get any sched_switch/wakeup etc events if debugfs is mounted anywhere
other than /sys/kernel/debug/. Mine was mounted in /debug (the second
sane location ;) )
So we'd need something like whats in the patch to make use of the global
debugfs_path.
Also, I'm assuming that parse-events.c is governed by GPLv2 or something
similar ?
Cheers,
Ashwin
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: perf-events-Remove-static-debugfs-path.patch --]
[-- Type: text/x-patch; name="perf-events-Remove-static-debugfs-path.patch", Size: 1106 bytes --]
>From 289657eaae162b6a5571894ec71d1ecca5454a54 Mon Sep 17 00:00:00 2001
From: Ashwin Chaugule <ashwinc@quicinc.com>
Date: Wed, 30 Sep 2009 13:36:58 -0400
Subject: [PATCH] [perf-events] Remove static debugfs path
Timechart doesn't work if debugfs is not in /sys/kernel/debug/.
Fixed by using global debugfs_path which is filled in by perf.
modified: tools/perf/util/parse-events.c
Signed-off-by: Ashwin Chaugule <ashwinc@quicinc.com>
---
tools/perf/util/parse-events.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 87c424d..c661c90 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -690,8 +690,11 @@ static void store_event_type(const char *orgname)
char filename[PATH_MAX], *c;
FILE *file;
int id;
+
+ sprintf(filename, "%s/", debugfs_path);
+ strncat(filename, orgname, strlen(orgname));
+ strcat(filename, "/id");
- sprintf(filename, "/sys/kernel/debug/tracing/events/%s/id", orgname);
c = strchr(filename, ':');
if (c)
*c = '/';
--
1.5.6.3
next reply other threads:[~2009-10-04 22:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-04 22:49 ashwinc [this message]
2009-10-12 20:41 ` [RFC] [PATCH 1/1] Remove static debugfs path from parse-events Ingo Molnar
2009-10-12 20:43 ` [tip:perf/urgent] perf tools: " tip-bot for Ashwin Chaugule
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a751bdc6978478de6d10440e587a2cc7.squirrel@www.codeaurora.org \
--to=ashwinc@codeaurora.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox