From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Alvin1 Chen <alvin1.chen@lcfc.corp-partner.google.com>
Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: samsung-atna33xc20: extend msleep in atana33xc20_disable to avoid glitch
Date: Fri, 25 Apr 2025 18:15:42 +0300 (EEST) [thread overview]
Message-ID: <a75efa75-a113-842c-d598-2c1405a5c29b@linux.intel.com> (raw)
In-Reply-To: <20250425105822.4061016-1-alvin1.chen@lcfc.corp-partner.google.com>
On Fri, 25 Apr 2025, Alvin1 Chen wrote:
> samsung-atna40ct03 encouters glitch when powering off, extend msleep
encounters
msleep()
I'd also suggest you describe the glitch a bit more than that.
> in atana33xc20_disable to 40 can avoid this symptom.
>
> Change-Id: I4d052621d3c3e0fdae0ac472fe5da151f46be237
> Signed-off-by: Alvin1 Chen <alvin1.chen@lcfc.corp-partner.google.com>
> ---
> drivers/gpu/drm/panel/panel-samsung-atna33xc20.c | 4 ++--
Please use scripts/get_maintainer.pl to send this v2 of this patch to
correct lists and people. Thanks.
--
i.
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> index 9a482a744b8c..87a4e1c47aaa 100644
> --- a/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> +++ b/drivers/gpu/drm/panel/panel-samsung-atna33xc20.c
> @@ -154,10 +154,10 @@ static int atana33xc20_disable(struct drm_panel *panel)
> p->el3_was_on = true;
>
> /*
> - * Sleeping 20 ms here (after setting the GPIO) avoids a glitch when
> + * Sleeping 40 ms here (after setting the GPIO) avoids a glitch when
> * powering off.
> */
> - msleep(20);
> + msleep(40);
>
> return 0;
> }
>
next prev parent reply other threads:[~2025-04-25 15:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-25 10:58 [PATCH] drm/panel: samsung-atna33xc20: extend msleep in atana33xc20_disable to avoid glitch Alvin1 Chen
2025-04-25 15:15 ` Ilpo Järvinen [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-01-22 11:31 Alvin1 Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a75efa75-a113-842c-d598-2c1405a5c29b@linux.intel.com \
--to=ilpo.jarvinen@linux.intel.com \
--cc=alvin1.chen@lcfc.corp-partner.google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox