From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753766AbdHWJcB (ORCPT ); Wed, 23 Aug 2017 05:32:01 -0400 Received: from fllnx210.ext.ti.com ([198.47.19.17]:21844 "EHLO fllnx210.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753658AbdHWJb7 (ORCPT ); Wed, 23 Aug 2017 05:31:59 -0400 Subject: Re: [PATCH] clk: ti: make clk_ops const To: Bhumika Goyal , , , , , , References: <1503407475-11620-1-git-send-email-bhumirks@gmail.com> From: Tero Kristo Message-ID: Date: Wed, 23 Aug 2017 12:31:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1503407475-11620-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v7N9W6Fv031800  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 22/08/17 16:11, Bhumika Goyal wrote: > Make these const as they are only stored in the const field of a > clk_init_data structure. > > Signed-off-by: Bhumika Goyal Looks fine. Acked-by: Tero Kristo > --- > drivers/clk/ti/adpll.c | 2 +- > drivers/clk/ti/apll.c | 2 +- > drivers/clk/ti/fapll.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/ti/adpll.c b/drivers/clk/ti/adpll.c > index 255cafb..d5c6db4 100644 > --- a/drivers/clk/ti/adpll.c > +++ b/drivers/clk/ti/adpll.c > @@ -486,7 +486,7 @@ static u8 ti_adpll_get_parent(struct clk_hw *hw) > return 0; > } > > -static struct clk_ops ti_adpll_ops = { > +static const struct clk_ops ti_adpll_ops = { > .prepare = ti_adpll_prepare, > .unprepare = ti_adpll_unprepare, > .is_prepared = ti_adpll_is_prepared, > diff --git a/drivers/clk/ti/apll.c b/drivers/clk/ti/apll.c > index 06f486b..83b148f 100644 > --- a/drivers/clk/ti/apll.c > +++ b/drivers/clk/ti/apll.c > @@ -304,7 +304,7 @@ static void omap2_apll_disable(struct clk_hw *hw) > ti_clk_ll_ops->clk_writel(v, &ad->control_reg); > } > > -static struct clk_ops omap2_apll_ops = { > +static const struct clk_ops omap2_apll_ops = { > .enable = &omap2_apll_enable, > .disable = &omap2_apll_disable, > .is_enabled = &omap2_apll_is_enabled, > diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c > index 66a0d0e..071af44 100644 > --- a/drivers/clk/ti/fapll.c > +++ b/drivers/clk/ti/fapll.c > @@ -268,7 +268,7 @@ static int ti_fapll_set_rate(struct clk_hw *hw, unsigned long rate, > return 0; > } > > -static struct clk_ops ti_fapll_ops = { > +static const struct clk_ops ti_fapll_ops = { > .enable = ti_fapll_enable, > .disable = ti_fapll_disable, > .is_enabled = ti_fapll_is_enabled, > @@ -478,7 +478,7 @@ static int ti_fapll_synth_set_rate(struct clk_hw *hw, unsigned long rate, > return 0; > } > > -static struct clk_ops ti_fapll_synt_ops = { > +static const struct clk_ops ti_fapll_synt_ops = { > .enable = ti_fapll_synth_enable, > .disable = ti_fapll_synth_disable, > .is_enabled = ti_fapll_synth_is_enabled, >