From: Krzysztof Kozlowski <krzk@kernel.org>
To: Henrik Grimler <henrik@grimler.se>,
Lukas Timmermann <linux@timmermann.space>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
Rob Herring <robh@kernel.org>, Conor Dooley <conor+dt@kernel.org>,
Alexandre Marquet <tb@a-marquet.fr>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] ARM: dts: exynos: Add Samsung Manta (Google Nexus 10)
Date: Thu, 20 Nov 2025 18:36:29 +0100 [thread overview]
Message-ID: <a78e1277-4148-435a-9a69-042507fab308@kernel.org> (raw)
In-Reply-To: <20251120173120.GA10065@localhost>
On 20/11/2025 18:31, Henrik Grimler wrote:
> Hi Lukas,
>
> On Thu, Nov 20, 2025 at 03:40:15PM +0100, Lukas Timmermann wrote:
>> From: Alexandre Marquet <tb@a-marquet.fr>
>>
>> Manta is the code name for Google Nexus 10, and was manufactured by
>> Samsung. This patch adds initial device-tree file for this board.
>>
>> Co-developed-by: Alexandre Marquet <tb@a-marquet.fr>
>> Signed-off-by: Alexandre Marquet <tb@a-marquet.fr>
>> Co-developed-by: Lukas Timmermann <linux@timmermann.space>
>> Signed-off-by: Lukas Timmermann <linux@timmermann.space>
>
> Awesome! I think this series would benefit from a cover letter
> explaining what features are working, and perhaps saying something
> about other patches that will be sent separately (if any). The as3668
> led driver and bindings for example has not been merged, right? Adding
> the lore link in a cover letter would therefore help reviewers.
If "not merged" in the meaning of not taken by maintainer for next, then
this is quite important because it not only blocks this patch but would
cause failures in CI leading me to being grumpy.
Samsung SoC follows maintainer-soc-clean-dts profile. Please always
explicitly document such stuff (bindings in fly).
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-11-20 17:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20251120144018.961604-1-linux@timmermann.space>
2025-11-20 14:40 ` [PATCH 1/3] dt-bindings: ARM: samsung: Add Samsung Manta (Google Nexus 10) Lukas Timmermann
2025-11-21 9:04 ` Krzysztof Kozlowski
2025-11-21 13:45 ` Lukas Timmermann
2025-11-21 17:24 ` Krzysztof Kozlowski
2025-11-21 18:07 ` Lukas Timmermann
2025-11-21 18:10 ` Krzysztof Kozlowski
2025-11-20 14:40 ` [PATCH 2/3] ARM: dts: exynos: " Lukas Timmermann
2025-11-20 17:31 ` Henrik Grimler
2025-11-20 17:36 ` Krzysztof Kozlowski [this message]
2025-11-20 20:27 ` Lukas Timmermann
2025-11-20 20:29 ` Lukas Timmermann
2025-11-20 14:40 ` [PATCH 3/3] ARM: samsung: exynos5250: Allow CPU1 to boot Lukas Timmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a78e1277-4148-435a-9a69-042507fab308@kernel.org \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux@timmermann.space \
--cc=robh@kernel.org \
--cc=tb@a-marquet.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox