From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Nicolas Dufresne <nicolas@ndufresne.ca>,
chunkuang.hu@kernel.org, Yunfei Dong <yunfei.dong@mediatek.com>,
Jason-JH Lin <jason-jh.lin@mediatek.com>
Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, mchehab@kernel.org, matthias.bgg@gmail.com,
moudy.ho@mediatek.com, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@collabora.com,
sebastian.fricke@collabora.com, macpaul.lin@mediatek.com
Subject: Re: [PATCH v1 2/3] dt-bindings: media: mediatek: mdp3: Add compatibles for MT8188 MDP3
Date: Wed, 19 Mar 2025 15:07:13 +0100 [thread overview]
Message-ID: <a79697fa-9ac0-4829-a36f-4e9915ad6bff@collabora.com> (raw)
In-Reply-To: <5682afd1785f37d9a995bee1643174b669c48535.camel@ndufresne.ca>
Il 19/02/25 16:38, Nicolas Dufresne ha scritto:
> Hi Angelo,
>
> Le mercredi 18 décembre 2024 à 11:53 +0100, AngeloGioacchino Del Regno
> a écrit :
>> Add compatible strings for the FG, HDR, RSZ, STITCH, TCC, TDSHP
>> and WROT hardware components found in MediaTek's MT8188 SoC.
>
> The firmware for this is missing in linux-firmware. I will not ack or
> pickMTK-VCODEC/MDP3 patches until this issue has been resolved.
>
Nicolas et al linux-media maintainers:
https://lore.kernel.org/all/CA+5PVA6a+g1rZOM+ZRsNr-e4C9DPagQrffRO36yO3Bt3UXJNfQ@mail.gmail.com/
We ran tests on the firmware that was pushed, and sent the results in
reply to the patch that adds the firmware:
https://lore.kernel.org/all/8049a2ec-b5fe-440d-9704-c3b0e2d610c7@notapiano
The SCP firmware for VCODEC and MDP3 on the MT8188/MT8370/MT8390 SoCs has
been merged in linux-firmware.
Can you please ack this patch now? :-)
Cheers,
Angelo
> regards,
> Nicolas
>
>>
>> This hardware is compatible with MT8195.
>>
>> Signed-off-by: AngeloGioacchino Del Regno
>> <angelogioacchino.delregno@collabora.com>
>> ---
>> .../devicetree/bindings/media/mediatek,mdp3-fg.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-hdr.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml | 1 +
>> .../devicetree/bindings/media/mediatek,mdp3-stitch.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-tcc.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-tdshp.yaml | 8
>> ++++++--
>> .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml | 1 +
>> 7 files changed, 32 insertions(+), 10 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> fg.yaml
>> index 03f31b009085..40fda59fa8a8 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-fg
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-fg
>> + - items:
>> + - const: mediatek,mt8188-mdp3-fg
>> + - const: mediatek,mt8195-mdp3-fg
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> hdr.yaml
>> index d4609bba6578..d9f926c20220 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-hdr
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-hdr
>> + - items:
>> + - const: mediatek,mt8188-mdp3-hdr
>> + - const: mediatek,mt8195-mdp3-hdr
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> rsz.yaml
>> index f5676bec4326..8124c39d73e9 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - mediatek,mt8183-mdp3-rsz
>> - items:
>> - enum:
>> + - mediatek,mt8188-mdp3-rsz
>> - mediatek,mt8195-mdp3-rsz
>> - const: mediatek,mt8183-mdp3-rsz
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> index d815bea29154..1d8e7e202c42 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> stitch.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-stitch
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-stitch
>> + - items:
>> + - const: mediatek,mt8188-mdp3-stitch
>> + - const: mediatek,mt8195-mdp3-stitch
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tcc.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tcc.yaml
>> index 14ea556d4f82..6cff7c073ce4 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml
>> @@ -17,8 +17,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-tcc
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-tcc
>> + - items:
>> + - const: mediatek,mt8188-mdp3-tcc
>> + - const: mediatek,mt8195-mdp3-tcc
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> index 8ab7f2d8e148..cdfa27324738 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> tdshp.yaml
>> @@ -16,8 +16,12 @@ description:
>>
>> properties:
>> compatible:
>> - enum:
>> - - mediatek,mt8195-mdp3-tdshp
>> + oneOf:
>> + - enum:
>> + - mediatek,mt8195-mdp3-tdshp
>> + - items:
>> + - const: mediatek,mt8188-mdp3-tdshp
>> + - const: mediatek,mt8195-mdp3-tdshp
>>
>> reg:
>> maxItems: 1
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-
>> wrot.yaml
>> index 53a679338402..b6269f4f9fd6 100644
>> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml
>> @@ -20,6 +20,7 @@ properties:
>> - mediatek,mt8183-mdp3-wrot
>> - items:
>> - enum:
>> + - mediatek,mt8188-mdp3-wrot
>> - mediatek,mt8195-mdp3-wrot
>> - const: mediatek,mt8183-mdp3-wrot
>>
>
next prev parent reply other threads:[~2025-03-19 14:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-18 10:53 [PATCH v1 0/3] MediaTek MT8188 MDP3 Enablement AngeloGioacchino Del Regno
2024-12-18 10:53 ` [PATCH v1 1/3] dt-bindings: display: mediatek: Add compatibles for MT8188 MDP3 AngeloGioacchino Del Regno
2024-12-18 16:54 ` Conor Dooley
2025-02-19 13:49 ` Chun-Kuang Hu
2025-02-19 14:03 ` AngeloGioacchino Del Regno
2025-04-14 12:40 ` Nicolas Dufresne
2024-12-18 10:53 ` [PATCH v1 2/3] dt-bindings: media: mediatek: mdp3: " AngeloGioacchino Del Regno
2024-12-18 16:55 ` Conor Dooley
2025-02-19 15:38 ` Nicolas Dufresne
2025-03-19 14:07 ` AngeloGioacchino Del Regno [this message]
2025-04-14 12:40 ` Nicolas Dufresne
2024-12-18 10:53 ` [PATCH v1 3/3] arm64: dts: mediatek: mt8188: Add all Multimedia Data Path 3 nodes AngeloGioacchino Del Regno
2025-02-12 11:09 ` [PATCH v1 0/3] MediaTek MT8188 MDP3 Enablement AngeloGioacchino Del Regno
2025-04-15 7:38 ` AngeloGioacchino Del Regno
2025-04-16 12:54 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a79697fa-9ac0-4829-a36f-4e9915ad6bff@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=airlied@gmail.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jason-jh.lin@mediatek.com \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=macpaul.lin@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=mripard@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=sebastian.fricke@collabora.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=yunfei.dong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).