From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bali.collaboradmins.com (bali.collaboradmins.com [148.251.105.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 627A21C460A; Wed, 19 Mar 2025 14:07:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.251.105.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742393239; cv=none; b=HyUvjZxSJggLNNhQQpscaXLui4rY9AbS9GMonyVS1Gj8FRrXemnZbF/fXTrHCEFIR5X+4XH2Qox7YfJl9+n3clrfLHOxx95sVjxUc7lPhWoKaxtXJ59OKXphALi2golnOW112BxqvR2WHlhywF01BXOcSoTwlXBRkbYhL3IG13c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742393239; c=relaxed/simple; bh=vpGjYI6Vrz1T1LESF45jAadrF+3ulmGVN9/2NRUNuGY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K8yehRkCwng8HJaSlifh1xCgJbeNuOrLNAoqjSXCdHD4tM+s3JV+35klWeO34qmlWNmK+Dl0IdLff3849MuGQc2VaoVj1jRni1mRtJnDqbv3WVlJxSHDJ5U+MStn/2EhzEXpv8RdBChl8YBCWWczkCoPhqJdpcYs6/FrgxrwR+k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=SZMdqj8U; arc=none smtp.client-ip=148.251.105.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="SZMdqj8U" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1742393235; bh=vpGjYI6Vrz1T1LESF45jAadrF+3ulmGVN9/2NRUNuGY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SZMdqj8US2vOliEoZQe9zqs9dmvk8BMMXT+I9LVY2ZLyGvCt80NrdWzi/bqRLk5BL L0g/P6jQHrtJaLqsjlDv/YJsSzgGVCWv1gZoGtVAdMxNEgXZvqEZTG075OCcl5viAN cOTC+wqAj0Jh9ChssaAYXgrD6ROvZIdd8Tf2FZN36mahwCz9qtuTY8Az5cP/f7vdDd Imj9G7dloskYXP6CBtW8kIIUSVFoghsAqDzxvI49Vv4LNjYQTY5CHinfwJUZPlj4rY uhYTUwJFSRGT8MS0C7sHYGC+4InfFz0nqsBZG29KofKrNJaZoc13VKzPmhbKXq1mqL JzcNajUleXZog== Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by bali.collaboradmins.com (Postfix) with ESMTPSA id 3087F17E05D9; Wed, 19 Mar 2025 15:07:14 +0100 (CET) Message-ID: Date: Wed, 19 Mar 2025 15:07:13 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/3] dt-bindings: media: mediatek: mdp3: Add compatibles for MT8188 MDP3 To: Nicolas Dufresne , chunkuang.hu@kernel.org, Yunfei Dong , Jason-JH Lin Cc: p.zabel@pengutronix.de, airlied@gmail.com, simona@ffwll.ch, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, mchehab@kernel.org, matthias.bgg@gmail.com, moudy.ho@mediatek.com, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kernel@collabora.com, sebastian.fricke@collabora.com, macpaul.lin@mediatek.com References: <20241218105320.38980-1-angelogioacchino.delregno@collabora.com> <20241218105320.38980-3-angelogioacchino.delregno@collabora.com> <5682afd1785f37d9a995bee1643174b669c48535.camel@ndufresne.ca> From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: <5682afd1785f37d9a995bee1643174b669c48535.camel@ndufresne.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Il 19/02/25 16:38, Nicolas Dufresne ha scritto: > Hi Angelo, > > Le mercredi 18 décembre 2024 à 11:53 +0100, AngeloGioacchino Del Regno > a écrit : >> Add compatible strings for the FG, HDR, RSZ, STITCH, TCC, TDSHP >> and WROT hardware components found in MediaTek's MT8188 SoC. > > The firmware for this is missing in linux-firmware. I will not ack or > pickMTK-VCODEC/MDP3 patches until this issue has been resolved. > Nicolas et al linux-media maintainers: https://lore.kernel.org/all/CA+5PVA6a+g1rZOM+ZRsNr-e4C9DPagQrffRO36yO3Bt3UXJNfQ@mail.gmail.com/ We ran tests on the firmware that was pushed, and sent the results in reply to the patch that adds the firmware: https://lore.kernel.org/all/8049a2ec-b5fe-440d-9704-c3b0e2d610c7@notapiano The SCP firmware for VCODEC and MDP3 on the MT8188/MT8370/MT8390 SoCs has been merged in linux-firmware. Can you please ack this patch now? :-) Cheers, Angelo > regards, > Nicolas > >> >> This hardware is compatible with MT8195. >> >> Signed-off-by: AngeloGioacchino Del Regno >> >> --- >>  .../devicetree/bindings/media/mediatek,mdp3-fg.yaml       | 8 >> ++++++-- >>  .../devicetree/bindings/media/mediatek,mdp3-hdr.yaml      | 8 >> ++++++-- >>  .../devicetree/bindings/media/mediatek,mdp3-rsz.yaml      | 1 + >>  .../devicetree/bindings/media/mediatek,mdp3-stitch.yaml   | 8 >> ++++++-- >>  .../devicetree/bindings/media/mediatek,mdp3-tcc.yaml      | 8 >> ++++++-- >>  .../devicetree/bindings/media/mediatek,mdp3-tdshp.yaml    | 8 >> ++++++-- >>  .../devicetree/bindings/media/mediatek,mdp3-wrot.yaml     | 1 + >>  7 files changed, 32 insertions(+), 10 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> fg.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> fg.yaml >> index 03f31b009085..40fda59fa8a8 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-fg.yaml >> @@ -16,8 +16,12 @@ description: >> >>  properties: >>    compatible: >> -    enum: >> -      - mediatek,mt8195-mdp3-fg >> +    oneOf: >> +      - enum: >> +          - mediatek,mt8195-mdp3-fg >> +      - items: >> +          - const: mediatek,mt8188-mdp3-fg >> +          - const: mediatek,mt8195-mdp3-fg >> >>    reg: >>      maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> hdr.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> hdr.yaml >> index d4609bba6578..d9f926c20220 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-hdr.yaml >> @@ -16,8 +16,12 @@ description: >> >>  properties: >>    compatible: >> -    enum: >> -      - mediatek,mt8195-mdp3-hdr >> +    oneOf: >> +      - enum: >> +          - mediatek,mt8195-mdp3-hdr >> +      - items: >> +          - const: mediatek,mt8188-mdp3-hdr >> +          - const: mediatek,mt8195-mdp3-hdr >> >>    reg: >>      maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> rsz.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> rsz.yaml >> index f5676bec4326..8124c39d73e9 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rsz.yaml >> @@ -20,6 +20,7 @@ properties: >>            - mediatek,mt8183-mdp3-rsz >>        - items: >>            - enum: >> +              - mediatek,mt8188-mdp3-rsz >>                - mediatek,mt8195-mdp3-rsz >>            - const: mediatek,mt8183-mdp3-rsz >> >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> stitch.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> stitch.yaml >> index d815bea29154..1d8e7e202c42 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> stitch.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> stitch.yaml >> @@ -16,8 +16,12 @@ description: >> >>  properties: >>    compatible: >> -    enum: >> -      - mediatek,mt8195-mdp3-stitch >> +    oneOf: >> +      - enum: >> +          - mediatek,mt8195-mdp3-stitch >> +      - items: >> +          - const: mediatek,mt8188-mdp3-stitch >> +          - const: mediatek,mt8195-mdp3-stitch >> >>    reg: >>      maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tcc.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tcc.yaml >> index 14ea556d4f82..6cff7c073ce4 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-tcc.yaml >> @@ -17,8 +17,12 @@ description: >> >>  properties: >>    compatible: >> -    enum: >> -      - mediatek,mt8195-mdp3-tcc >> +    oneOf: >> +      - enum: >> +          - mediatek,mt8195-mdp3-tcc >> +      - items: >> +          - const: mediatek,mt8188-mdp3-tcc >> +          - const: mediatek,mt8195-mdp3-tcc >> >>    reg: >>      maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tdshp.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tdshp.yaml >> index 8ab7f2d8e148..cdfa27324738 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tdshp.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> tdshp.yaml >> @@ -16,8 +16,12 @@ description: >> >>  properties: >>    compatible: >> -    enum: >> -      - mediatek,mt8195-mdp3-tdshp >> +    oneOf: >> +      - enum: >> +          - mediatek,mt8195-mdp3-tdshp >> +      - items: >> +          - const: mediatek,mt8188-mdp3-tdshp >> +          - const: mediatek,mt8195-mdp3-tdshp >> >>    reg: >>      maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- >> wrot.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- >> wrot.yaml >> index 53a679338402..b6269f4f9fd6 100644 >> --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml >> +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-wrot.yaml >> @@ -20,6 +20,7 @@ properties: >>            - mediatek,mt8183-mdp3-wrot >>        - items: >>            - enum: >> +              - mediatek,mt8188-mdp3-wrot >>                - mediatek,mt8195-mdp3-wrot >>            - const: mediatek,mt8183-mdp3-wrot >> >