From: "Nazle Asmade, Muhammad Nazim Amirul" <muhammad.nazim.amirul.nazle.asmade@altera.com>
To: Dinh Nguyen <dinguyen@kernel.org>
Cc: "robh@kernel.org" <robh@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] arm64: dts: socfpga: Add dma-coherent to XGMAC nodes
Date: Fri, 15 May 2026 08:02:36 +0000 [thread overview]
Message-ID: <a7bd462b-a46a-43ca-810b-79e21be90fe9@altera.com> (raw)
In-Reply-To: <51c01dfc-d6b2-4605-81bd-496211947c1f@kernel.org>
On 15/5/2026 7:43 am, Dinh Nguyen wrote:
>
>
> On 5/14/26 06:41, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
>> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>>
>> The SMMU is enabled and transactions going through it are cache
>> coherent. Add the dma-coherent property to the XGMAC nodes to prevent
>> redundant cache flush/invalidate operations and potential stale data
>> issues.
>>
>> Signed-off-by: Nazim Amirul
>> <muhammad.nazim.amirul.nazle.asmade@altera.com>
>> ---
>> arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts | 1 +
>> arch/arm64/boot/dts/intel/socfpga_agilex5_socdk.dts | 1 +
>> arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_013b.dts | 1 +
>> arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_modular.dts | 1 +
>> arch/arm64/boot/dts/intel/socfpga_agilex5_socdk_nand.dts | 1 +
>> 5 files changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts b/
>> arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
>> index 25e17df0cbdb..2061d301126e 100644
>> --- a/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
>> +++ b/arch/arm64/boot/dts/intel/socfpga_agilex3_socdk.dts
>> @@ -52,6 +52,7 @@ &gmac2 {
>> phy-mode = "rgmii-id";
>> phy-handle = <&emac2_phy0>;
>> max-frame-size = <9000>;
>> + dma-coherent;
> This property should be in placed in the Agilex5 dtsi file.
>
> Thanks,
> Dinh
All the changes had been reflected in v2. Thanks Dinh!
https://lore.kernel.org/all/20260515080014.6260-1-muhammad.nazim.amirul.nazle.asmade@altera.com/
https://lore.kernel.org/all/20260515080014.6260-2-muhammad.nazim.amirul.nazle.asmade@altera.com/
https://lore.kernel.org/all/20260515080014.6260-3-muhammad.nazim.amirul.nazle.asmade@altera.com/
BR,
Nazim
prev parent reply other threads:[~2026-05-15 8:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 11:41 [PATCH 0/2] arm64: dts: socfpga: Enable SMMU and add DMA coherency for XGMAC muhammad.nazim.amirul.nazle.asmade
2026-05-14 11:41 ` [PATCH 1/2] arm64: dts: socfpga: Enable the SMMU for SoCFPGA device trees muhammad.nazim.amirul.nazle.asmade
2026-05-14 23:34 ` Dinh Nguyen
2026-05-14 11:41 ` [PATCH 2/2] arm64: dts: socfpga: Add dma-coherent to XGMAC nodes muhammad.nazim.amirul.nazle.asmade
2026-05-14 23:43 ` Dinh Nguyen
2026-05-15 8:02 ` Nazle Asmade, Muhammad Nazim Amirul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7bd462b-a46a-43ca-810b-79e21be90fe9@altera.com \
--to=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox