From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9649EB64D9 for ; Thu, 29 Jun 2023 08:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232465AbjF2IVg (ORCPT ); Thu, 29 Jun 2023 04:21:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232287AbjF2IUI (ORCPT ); Thu, 29 Jun 2023 04:20:08 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 41F5A1FFA; Thu, 29 Jun 2023 01:18:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688026736; x=1719562736; h=message-id:date:mime-version:from:subject:to:cc: references:in-reply-to:content-transfer-encoding; bh=nZeawW1oMN2HuGCf+TgAnAiNf1H7F95ZCg0NNjoviRI=; b=AcInyjof8vSX9VG0LJ0MS50C95n4MLOGfaJ1kDwB/ZvcJwsGmtiValQu khiQUoY+gZ6WGHhlhy+L+ZYnn81z236js3/fvJ/PM3+GawTVq8/D+m5HZ 2xOU+fOCT2k1IEJG3bMyOZZi4vSBdVDQAFmY+qLIW109N/KP9x6jwwUcT mnHHInzsY1SFnhRziOtf/rnkDn5yFeV+LiVYKApFQXXQgSKCuBedo/CW5 8rSUI/4lxPbc8j7rbMLWtb8cQKWXnqw3EyZfZGrYUEu5CTz8MawbU75tz 3lu1FKYL9lcmvFuQ/1YxlXo8SU8HuO2R19Oa5m8gH2gEdDoJQTGJie4WP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="351854300" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="351854300" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 01:18:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="891331178" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="891331178" Received: from aslawinx-mobl.ger.corp.intel.com (HELO [10.99.16.144]) ([10.99.16.144]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 01:18:53 -0700 Message-ID: Date: Thu, 29 Jun 2023 10:18:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 From: =?UTF-8?Q?Amadeusz_S=c5=82awi=c5=84ski?= Subject: Re: [RFC PATCH 1/8] PCI: Add Intel Audio DSP devices to pci_ids.h To: Andy Shevchenko Cc: Bjorn Helgaas , Mark Brown , Takashi Iwai , alsa-devel@alsa-project.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Cezary Rojewski , Pierre-Louis Bossart , Kai Vehmanen References: <20230628205135.517241-1-amadeuszx.slawinski@linux.intel.com> <20230628205135.517241-2-amadeuszx.slawinski@linux.intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/28/2023 4:44 PM, Andy Shevchenko wrote: > On Wed, Jun 28, 2023 at 10:51:28PM +0200, Amadeusz Sławiński wrote: >> Those IDs are mostly sprinkled between HDA, Skylake, SOF and avs drivers. >> Almost every use contains additional comments to identify to which >> platform those IDs refer to. Add those IDs to pci_ids.h header, so that >> there is one place which defines those names. > > ... > >> #define PCI_DEVICE_ID_INTEL_5400_FBD0 0x4035 >> #define PCI_DEVICE_ID_INTEL_5400_FBD1 0x4036 >> +#define PCI_DEVICE_ID_INTEL_HDA_JSL_N 0x4dc8 >> +#define PCI_DEVICE_ID_INTEL_HDA_TGL_H 0x43c8 >> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_0 0x4b55 >> +#define PCI_DEVICE_ID_INTEL_HDA_EHL_3 0x4b58 > > Can it be kept sorted by a value? > > Didn't check the full list, though. > My mistake, I've tried to add them in order, but must have missed this one, will review whole list again.