The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Alex Yeo <alexyeo362@gmail.com>
To: "Guenter Roeck" <linux@roeck-us.net>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: platform-driver-x86@vger.kernel.org,
	Kenneth Chan <kenneth.t.chan@gmail.com>,
	Hans de Goede <hansg@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-hwmon@vger.kernel.org
Subject: Re: [RFC PATCH v7] platform/x86: panasonic-laptop: add fan speed mode for newer models
Date: Wed, 29 Jul 2026 10:08:32 +0800	[thread overview]
Message-ID: <a7ee7c9b-8d23-48ec-97ff-c0b9bcf3bb63@gmail.com> (raw)
In-Reply-To: <635a0d22-8565-4c62-94d5-2cbaff308558@roeck-us.net>

On 2026/07/22 8:00 AM, Guenter Roeck wrote:
> 
> I for my part would like to understand why hwmon_lock() / hwmon_unlock()
> (or the hwmon_lock guard) are not sufficient. You suggest above that they
> are not sufficient and that you need the additional pwm_fan_lock, but you
> don't really explain the reason. You do explain that you need to lock the
> thermal access functions, and I agree, but you do not explain why the hwmon
> subsystem lock functions can not be used. It would be important to
> understand why that is the case because those functions exist for exactly
> that purpose. If they are insufficient, it is important to understand why
> that is the case.
> 
> Thanks,
> Guenter
> 

I have reworked the code to use hwmon_lock() via guard. I have tested 
the code on my machine and it works as expected. As a result, hwmon is 
now the primary owner of the fan.

I will submit a v8 patch with more details.

Thanks

  reply	other threads:[~2026-07-29  2:08 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260626054735.81BA51F00A3A@smtp.kernel.org>
2026-06-28  5:33 ` [RFC PATCH v6] platform/x86: panasonic-laptop: add fan speed mode for newer models Alex Yeo
2026-07-03 12:11   ` Ilpo Järvinen
2026-07-18 18:57     ` [RFC PATCH v7] " Alex Yeo
2026-07-20 13:46       ` Ilpo Järvinen
2026-07-20 14:41         ` Guenter Roeck
2026-07-21 23:22           ` Alex Yeo
2026-07-22  0:00             ` Guenter Roeck
2026-07-29  2:08               ` Alex Yeo [this message]
2026-07-21 22:10         ` Alex Yeo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a7ee7c9b-8d23-48ec-97ff-c0b9bcf3bb63@gmail.com \
    --to=alexyeo362@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=kenneth.t.chan@gmail.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox