From: Laura Abbott <labbott@redhat.com>
To: "Antti Keränen" <detegr@gmail.com>
Cc: sumit.semwal@linaro.org, gregkh@linuxfoundation.org,
arve@android.com, riandrews@android.com, bhaktipriya96@gmail.com,
yudongbin@hisilicon.com, puck.chen@hisilicon.com,
weiyongjun1@huawei.com, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/2] staging: ion: Fix a coding style issue
Date: Thu, 22 Sep 2016 13:15:02 -0700 [thread overview]
Message-ID: <a7eee403-0aba-e91c-6646-45c8b73c86a0@redhat.com> (raw)
In-Reply-To: <20160922155924.13299-1-detegr@gmail.com>
On 09/22/2016 08:59 AM, Antti Keränen wrote:
> Remove unnecessary braces surrounding a single statement block
>
In the future, when sending different versions of a patch please
give a short summary of what's changed. I think this is just
a resend from v2 with more reviewers added but I'm not 100%
sure.
> Signed-off-by: Antti Keränen <detegr@gmail.com>
> ---
You can put your summary right here between the --- and the
diffstat.
> drivers/staging/android/ion/hisilicon/hi6220_ion.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/android/ion/hisilicon/hi6220_ion.c b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> index 659aa71..bd45151 100644
> --- a/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> +++ b/drivers/staging/android/ion/hisilicon/hi6220_ion.c
> @@ -82,9 +82,9 @@ static int hi6220_ion_remove(struct platform_device *pdev)
>
> ipdev = platform_get_drvdata(pdev);
>
> - for (i = 0; i < ipdev->data->nr; i++) {
> + for (i = 0; i < ipdev->data->nr; i++)
> ion_heap_destroy(ipdev->heaps[i]);
> - }
> +
> ion_destroy_platform_data(ipdev->data);
> ion_device_destroy(ipdev->idev);
>
>
The patch looks fine though so assuming nothing else has
changed
Acked-by: Laura Abbott <labbott@redhat.com>
next prev parent reply other threads:[~2016-09-22 20:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160922151758.GB3565@kroah.com>
2016-09-22 15:59 ` [PATCH v3 1/2] staging: ion: Fix a coding style issue Antti Keränen
2016-09-22 20:15 ` Laura Abbott [this message]
2016-09-22 15:59 ` [PATCH v3 2/2] " Antti Keränen
2016-09-22 20:24 ` Laura Abbott
2016-09-23 18:03 ` [PATCH v4] " Antti Keränen
2016-09-23 20:36 ` Laura Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7eee403-0aba-e91c-6646-45c8b73c86a0@redhat.com \
--to=labbott@redhat.com \
--cc=arve@android.com \
--cc=bhaktipriya96@gmail.com \
--cc=detegr@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=puck.chen@hisilicon.com \
--cc=riandrews@android.com \
--cc=sumit.semwal@linaro.org \
--cc=weiyongjun1@huawei.com \
--cc=yudongbin@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox