Re: [PATCH 13/18] platform/x86: thinkpad_acpi: Use devm_platform_profile_register()

Mario Limonciello
2025-01-09T16:45:54Z

On 1/9/2025 09:06, Kurt Borja wrote:
> Replace platform_profile_register() with it's device managed version.
>
> Signed-off-by: Kurt Borja <kuurtb@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> drivers/platform/x86/thinkpad_acpi.c | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
> index a72790cc5e0e..a0b8987bc328 100644
> --- a/drivers/platform/x86/thinkpad_acpi.c
> +++ b/drivers/platform/x86/thinkpad_acpi.c
> @@ -10649,7 +10649,7 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
>
> dytc_profile.dev = &tpacpi_pdev->dev;
> /* Create platform_profile structure and register */
> - err = platform_profile_register(&dytc_profile, NULL);
> + err = devm_platform_profile_register(&dytc_profile, NULL);
> /*
> * If for some reason platform_profiles aren't enabled
> * don't quit terminally.
> @@ -10667,14 +10667,8 @@ static int tpacpi_dytc_profile_init(struct ibm_init_struct *iibm)
> return 0;
> }
>
> -static void dytc_profile_exit(void)
> -{
> - platform_profile_remove(&dytc_profile);
> -}
> -
> static struct ibm_struct dytc_profile_driver_data = {
> .name = "dytc-profile",
> - .exit = dytc_profile_exit,
> };
>
> /*************************************************************************