From: Baolu Lu <baolu.lu@linux.intel.com>
To: Jerry Snitselaar <jsnitsel@redhat.com>
Cc: baolu.lu@linux.intel.com, Joerg Roedel <jroedel@suse.de>,
Kyung Min Park <kyung.min.park@intel.com>,
Steve Wahl <steve.wahl@hpe.com>,
David Woodhouse <dwmw2@infradead.org>,
Will Deacon <will@kernel.org>,
iommu@lists.linux-foundation.org,
Mike Travis <mike.travis@hpe.com>,
Dimitri Sivanich <sivanich@hpe.com>,
Russ Anderson <russ.anderson@hpe.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting
Date: Tue, 14 Jun 2022 09:33:20 +0800 [thread overview]
Message-ID: <a827193a-2cd3-7d9f-1bb2-3f4be6ae193e@linux.intel.com> (raw)
In-Reply-To: <20220613203842.zyncvndwfauef2yh@cantor>
On 2022/6/14 04:38, Jerry Snitselaar wrote:
> On Thu, May 12, 2022 at 10:13:09AM -0500, Steve Wahl wrote:
>> To support up to 64 sockets with 10 DMAR units each (640), make the
>> value of DMAR_UNITS_SUPPORTED adjustable by a config variable,
>> CONFIG_DMAR_UNITS_SUPPORTED, and make it's default 1024 when MAXSMP is
>> set.
>>
>> If the available hardware exceeds DMAR_UNITS_SUPPORTED (previously set
>> to MAX_IO_APICS, or 128), it causes these messages: "DMAR: Failed to
>> allocate seq_id", "DMAR: Parse DMAR table failure.", and "x2apic: IRQ
>> remapping doesn't support X2APIC mode x2apic disabled"; and the system
>> fails to boot properly.
>>
>> Signed-off-by: Steve Wahl <steve.wahl@hpe.com>
>> ---
>>
>> Note that we could not find a reason for connecting
>> DMAR_UNITS_SUPPORTED to MAX_IO_APICS as was done previously. Perhaps
>> it seemed like the two would continue to match on earlier processors.
>> There doesn't appear to be kernel code that assumes that the value of
>> one is related to the other.
>>
>> v2: Make this value a config option, rather than a fixed constant. The default
>> values should match previous configuration except in the MAXSMP case. Keeping the
>> value at a power of two was requested by Kevin Tian.
>>
>> drivers/iommu/intel/Kconfig | 6 ++++++
>> include/linux/dmar.h | 6 +-----
>> 2 files changed, 7 insertions(+), 5 deletions(-)
>>
>
> Baolu do you have this queued up for v5.20? Also do you have a public repo where
> you keep the vt-d changes before sending Joerg the patches for a release?
Yes. I have started to queue patches for v5.20. They could be found on
github:
https://github.com/LuBaolu/intel-iommu/commits/vtd-next-for-v5.20
Best regards,
baolu
next prev parent reply other threads:[~2022-06-14 1:33 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-05 19:46 [PATCH] iommu/vt-d: Increase DMAR_UNITS_SUPPORTED Steve Wahl
2022-05-06 5:57 ` Baolu Lu
2022-05-06 6:49 ` Tian, Kevin
2022-05-06 7:10 ` Rodel, Jorg
2022-05-06 7:47 ` Tian, Kevin
2022-05-06 7:16 ` David Woodhouse
2022-05-06 8:12 ` Tian, Kevin
2022-05-06 15:26 ` Steve Wahl
2022-05-10 1:16 ` Tian, Kevin
2022-05-10 19:06 ` Steve Wahl
2022-05-11 3:36 ` Tian, Kevin
2022-05-12 15:13 ` [PATCH v2] iommu/vt-d: Make DMAR_UNITS_SUPPORTED a config setting Steve Wahl
2022-05-12 23:12 ` Steve Wahl
2022-05-13 2:09 ` Baolu Lu
2022-05-18 19:58 ` Steve Wahl
2022-05-23 6:43 ` Tian, Kevin
2022-06-13 20:38 ` Jerry Snitselaar
2022-06-14 1:33 ` Baolu Lu [this message]
2022-06-13 20:57 ` Jerry Snitselaar
2022-06-14 1:36 ` Baolu Lu
2022-06-14 1:44 ` Jerry Snitselaar
2022-06-14 1:51 ` Baolu Lu
2022-06-14 1:54 ` Jerry Snitselaar
2022-06-14 2:21 ` Baolu Lu
2022-06-14 16:45 ` Steve Wahl
2022-06-14 19:01 ` Jerry Snitselaar
2022-06-14 21:12 ` Steve Wahl
2022-06-15 1:38 ` Baolu Lu
2022-06-15 15:02 ` Steve Wahl
2022-06-15 18:36 ` [PATCH v3] " Steve Wahl
2022-06-15 18:39 ` Jerry Snitselaar
2022-06-22 14:52 ` Baolu Lu
2022-06-22 15:05 ` Jerry Snitselaar
2022-06-22 15:11 ` Steve Wahl
2022-06-23 2:29 ` Baolu Lu
2022-06-23 2:51 ` Jerry Snitselaar
2022-06-23 3:38 ` Baolu Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a827193a-2cd3-7d9f-1bb2-3f4be6ae193e@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=jsnitsel@redhat.com \
--cc=kyung.min.park@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.travis@hpe.com \
--cc=russ.anderson@hpe.com \
--cc=sivanich@hpe.com \
--cc=steve.wahl@hpe.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox