From: Taeung Song <treeze.taeung@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Wang Nan <wangnan0@huawei.com>,
Steven Rostedt <rostedt@goodmis.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration
Date: Tue, 31 Jan 2017 11:37:41 +0900 [thread overview]
Message-ID: <a84646ce-671e-9dfc-680c-38ceadba1f2d@gmail.com> (raw)
In-Reply-To: <20170130123858.GA11068@krava>
On 01/30/2017 09:38 PM, Jiri Olsa wrote:
> On Mon, Jan 30, 2017 at 07:32:03PM +0900, Taeung Song wrote:
>
> SNIP
>
>>> looks almost the same as for_each_event_system macro,
>>> what's the difference other than 'ftrace' check?
>>
>> Little thing.
>> In parse-events.c for_each_event macro contains
>> tp_event_has_id() function But this function isn't used in
>> util/trace-event-info.c
>>
>>> also why's one 'file' and the other 'system'? looks
>>
>> Just, I follow the name of each function that use the macros..
>>
>>> like we coud have just one macro in here
>>>
>>
>> I understood. :)
>> How about this ?
>
>
> looks ok, but can't apply it.. it's probably mangled
>
I got it.
I'll resend this changed patch!
Thanks,
Taeung
prev parent reply other threads:[~2017-01-31 2:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 8:35 [PATCH] perf tools: Create for_each_event{_system, _file} macros for tracepoints iteration Taeung Song
2017-01-30 9:08 ` Jiri Olsa
2017-01-30 10:32 ` Taeung Song
2017-01-30 12:38 ` Jiri Olsa
2017-01-31 2:37 ` Taeung Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84646ce-671e-9dfc-680c-38ceadba1f2d@gmail.com \
--to=treeze.taeung@gmail.com \
--cc=acme@kernel.org \
--cc=fweisbec@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox