From: Stephen Boyd <sboyd@kernel.org>
To: Yang Li <yang.lee@linux.alibaba.com>
Cc: mturquette@baylibre.com, orsonzhai@gmail.com,
baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com,
pdeschrijver@nvidia.com, pgaikwad@nvidia.com,
thierry.reding@gmail.com, jonathanh@nvidia.com,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Li <yang.lee@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH -next 3/3] clk: tegra: Fix unsigned comparison with less than zero
Date: Wed, 14 Jun 2023 13:01:51 -0700 [thread overview]
Message-ID: <a84d57dad7b69d0b8bc142b7522d214d.sboyd@kernel.org> (raw)
In-Reply-To: <20230614012913.122220-3-yang.lee@linux.alibaba.com>
Quoting Yang Li (2023-06-13 18:29:13)
> The return value of the round_rate() is long. However, the
> return value is being assigned to an unsigned long variable
> 'rate', so making 'rate' to long.
>
> silence the warnings:
> ./drivers/clk/tegra/clk-periph.c:59:5-9: WARNING: Unsigned expression compared with zero: rate < 0
> ./drivers/clk/tegra/clk-super.c:156:5-9: WARNING: Unsigned expression compared with zero: rate < 0
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=5519
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/clk/tegra/clk-periph.c | 2 +-
> drivers/clk/tegra/clk-super.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Instead of this can you implement determine_rate() for div_ops?
prev parent reply other threads:[~2023-06-14 20:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 1:29 [PATCH -next 1/3] clk: sprd: composite: Fix unsigned comparison with less than zero Yang Li
2023-06-14 1:29 ` [PATCH -next 2/3] clk: stm32: core: " Yang Li
2023-06-14 19:57 ` Stephen Boyd
2023-06-14 1:29 ` [PATCH -next 3/3] clk: tegra: " Yang Li
2023-06-14 20:01 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a84d57dad7b69d0b8bc142b7522d214d.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=abaci@linux.alibaba.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=jonathanh@nvidia.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=orsonzhai@gmail.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgaikwad@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=yang.lee@linux.alibaba.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox