From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1910FEB64D9 for ; Wed, 14 Jun 2023 20:02:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235103AbjFNUCA (ORCPT ); Wed, 14 Jun 2023 16:02:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42882 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233699AbjFNUB6 (ORCPT ); Wed, 14 Jun 2023 16:01:58 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8FDB4ED; Wed, 14 Jun 2023 13:01:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C69763417; Wed, 14 Jun 2023 20:01:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7260DC433C0; Wed, 14 Jun 2023 20:01:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1686772913; bh=Lc/Rqufcz6igZq8RYtflG4DSafdtKCVG2zc6qVTzzyA=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=hwm2Eb1VAdk+3mcWEaEgruZ15/DaTT6uIfavlckKcuJxZXkDH2lCjkZoC52/juU9c dAhYmvqQ7m7OWWFJpMxOILRQkgCXFDAd898Me6JDP1a5pi2WKA5UD9ddNwHmoV1Y7m YIzm6Lp1N5M5Noc38PSWJiGFjpdJJ3U2pIgNN/GBzDFQIBekdzoJ8EJ0hj+niZRr7Y tFcADITXMY0/0hQowqZaiX02f0tu/hgZKag/kLLJ0UT8k+dPCOFTRcD0LMtV8ULWBl NAxFT7pA/vpYwp6+imdajTfcg2+PHSAcRMNd8pw63msD48BMbH2PJCUot4/s4Bo2Mm 8byb00WXpcchA== Message-ID: Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20230614012913.122220-3-yang.lee@linux.alibaba.com> References: <20230614012913.122220-1-yang.lee@linux.alibaba.com> <20230614012913.122220-3-yang.lee@linux.alibaba.com> Subject: Re: [PATCH -next 3/3] clk: tegra: Fix unsigned comparison with less than zero From: Stephen Boyd Cc: mturquette@baylibre.com, orsonzhai@gmail.com, baolin.wang@linux.alibaba.com, zhang.lyra@gmail.com, pdeschrijver@nvidia.com, pgaikwad@nvidia.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Yang Li , Abaci Robot To: Yang Li Date: Wed, 14 Jun 2023 13:01:51 -0700 User-Agent: alot/0.10 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Yang Li (2023-06-13 18:29:13) > The return value of the round_rate() is long. However, the > return value is being assigned to an unsigned long variable > 'rate', so making 'rate' to long. >=20 > silence the warnings: > ./drivers/clk/tegra/clk-periph.c:59:5-9: WARNING: Unsigned expression com= pared with zero: rate < 0 > ./drivers/clk/tegra/clk-super.c:156:5-9: WARNING: Unsigned expression com= pared with zero: rate < 0 >=20 > Reported-by: Abaci Robot > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=3D5519 > Signed-off-by: Yang Li > --- > drivers/clk/tegra/clk-periph.c | 2 +- > drivers/clk/tegra/clk-super.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) Instead of this can you implement determine_rate() for div_ops?