From: Robin Murphy <robin.murphy@arm.com>
To: Christoph Hellwig <hch@lst.de>,
Marek Szyprowski <m.szyprowski@samsung.com>
Cc: iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value
Date: Tue, 30 Jul 2024 14:13:18 +0100 [thread overview]
Message-ID: <a86ca03d-13ab-4304-879d-ac4cbacabfa5@arm.com> (raw)
In-Reply-To: <20240723000604.241443-1-hch@lst.de>
On 23/07/2024 1:05 am, Christoph Hellwig wrote:
> Hi all,
>
> the above three functions can only return errors if the bus code failed
> to allocate the dma_parms structure, which is a grave error that won't
> get us far. Thus remove the pointless return values, that so far have
> fortunately been mostly ignored, but which the cleanup brigade now wants
> to check for for no good reason.
>
> I'd love to get this in after -rc1 so that we can catch any of those
> cleanups that might be queued up for this merge window.
Indeed, I think this is long overdue ever since the responsibility for
dma_parms was moved from these callers into bus code. For the series,
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
next prev parent reply other threads:[~2024-07-30 13:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-23 0:05 remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value Christoph Hellwig
2024-07-23 0:05 ` [PATCH 1/3] dma-mapping: don't return errors from dma_set_min_align_mask Christoph Hellwig
2024-07-23 0:05 ` [PATCH 2/3] dma-mapping: don't return errors from dma_set_seg_boundary Christoph Hellwig
2024-08-01 12:00 ` Marek Szyprowski
2024-08-01 12:36 ` Robin Murphy
2024-08-01 13:33 ` Christoph Hellwig
2024-08-02 11:53 ` Robin Murphy
2024-07-23 0:05 ` [PATCH 3/3] dma-mapping: don't return errors from dma_set_max_seg_size Christoph Hellwig
2024-07-30 13:13 ` Robin Murphy [this message]
2024-07-30 15:20 ` remove the dma_set_{max_seg_size,seg_boundary,min_align_mask} return value Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a86ca03d-13ab-4304-879d-ac4cbacabfa5@arm.com \
--to=robin.murphy@arm.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox