From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
netdev@vger.kernel.org, Andre Edich <andre.edich@microchip.com>,
Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH net v4 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up
Date: Thu, 18 Sep 2025 21:48:33 +0200 [thread overview]
Message-ID: <a873e8e3-e1c9-4e82-b3e8-4b1cc8052a73@lunn.ch> (raw)
In-Reply-To: <aMqw4LuoTTRspqfA@pengutronix.de>
> How about a minimal change instead: conditionally call
> phy_queue_state_machine() from lan87xx_config_aneg()? That would trigger
> a poll in the broken mode without touching phydev->irq or core teardown
> paths. Seems less intrusive than rewriting IRQ handling.
It is currently a static function, so that would have to change.
Or it might be better to add phy_trigger_machine_soon(), using the
default 1 second delay? And i would document it as only to be used by
broken PHYs, to try to stop it being abused. Anybody using it needs to
acknowledge their PHY is broken.
Andrew
next prev parent reply other threads:[~2025-09-18 19:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 9:52 [PATCH net v4 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up Oleksij Rempel
2025-07-14 9:52 ` [PATCH net v4 1/3] net: phy: enable polling when driver implements get_next_update_time Oleksij Rempel
2025-07-14 9:52 ` [PATCH net v4 2/3] net: phy: allow drivers to disable polling via get_next_update_time() Oleksij Rempel
2025-07-14 9:52 ` [PATCH net v4 3/3] net: phy: smsc: recover missed link-up IRQs on LAN8700 with adaptive polling Oleksij Rempel
2025-07-17 0:20 ` [PATCH net v4 0/3] net: phy: smsc: use IRQ + relaxed polling to fix missed link-up Jakub Kicinski
2025-07-18 13:58 ` Andrew Lunn
2025-09-17 13:00 ` Oleksij Rempel
2025-09-18 19:48 ` Andrew Lunn [this message]
2025-09-18 20:08 ` Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a873e8e3-e1c9-4e82-b3e8-4b1cc8052a73@lunn.ch \
--to=andrew@lunn.ch \
--cc=andre.edich@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lukas@wunner.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox